1893466 - Crash in [@ mozilla::nsCookieBannerTelemetryService::MaybeReportGoogleGDPRChoiceTelemetry]

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

10-20 crashes from 3-6 installs for 126.0 beta 3 and 4

Crash report: https://crash-stats.mozilla.org/report/index/6402c5cd-8207-4959-863b-02bab0240425

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames:

0  xul.dll  mozilla::nsCookieBannerTelemetryService::MaybeReportGoogleGDPRChoiceTelemetry...  toolkit/components/cookiebanners/nsCookieBannerTelemetryService.cpp:251
1  xul.dll  nsObserverList::NotifyObservers(nsISupports*, char const*, char16_t const*)  xpcom/ds/nsObserverList.cpp:71
1  xul.dll  nsObserverService::NotifyObservers(nsISupports*, char const*, char16_t const*)  xpcom/ds/nsObserverService.cpp:289
2  xul.dll  XPTC__InvokebyIndex
3  xul.dll  NS_InvokeByIndex(nsISupports*, unsigned int, unsigned int, nsXPTCVariant*)  xpcom/reflect/xptcall/md/win32/xptcinvoke_x86_64.cpp:57
3  xul.dll  CallMethodHelper::Invoke()  js/xpconnect/src/XPCWrappedNative.cpp:1621
3  xul.dll  CallMethodHelper::Call()  js/xpconnect/src/XPCWrappedNative.cpp:1174
3  xul.dll  XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode)  js/xpconnect/src/XPCWrappedNative.cpp:1120
4  xul.dll  XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*)  js/xpconnect/src/XPCWrappedNativeJSOps.cpp:966
5  xul.dll  CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::...  js/src/vm/Interpreter.cpp:479

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1893466 - Don't collect Google GDRP telemetry if no default search engine is available. r?pbz!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 20 desktop browser crashes on beta

For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60c445d075af
Don't collect Google GDRP telemetry if no default search engine is available. r=pbz

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/60c445d075af

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:timhuang, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox126 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1893466 - Don't collect Google GDRP telemetry if no default search engine is available.

Original Revision: https://phabricator.services.mozilla.com/D208724

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Firefox will crash if no default search engine is available.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: Low
• Explanation of risk level: The change is small and shouldn't affect any user behavior.
• String changes made/needed: no
• Is Android affected?: yes

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/77f3883b630a