Closed Bug 1893527 Opened 10 months ago Closed 8 months ago

[Toolbar redesign] Add app menu to landscape/tablet address bar

Categories

(Fenix :: Toolbar, task, P1)

Product:
Fenix
Component:
Toolbar
Platform:
All
Android
Type:
task

Tracking

(firefox129 fixed)

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: royang, Assigned: mavduevskiy)

References

Details

(Whiteboard: [fxdroid])

Attachments

(2 files)

Bug 1893527 - Change menu button visibility based on that of navbar
48 bytes, text/x-phabricator-request
Details | Review
Bug 1893527 - Fix menu visibility in landscape/tablet when navbar is on
48 bytes, text/x-phabricator-request
Details | Review

figma shows that menu button should show when we're in landscape or tablet mode.

Blocks: android-toolbar-redesign
Summary: [Toolbar redesign] Add tabs tray to landscape/tablet address bar → [Toolbar redesign] Add app menu to landscape/tablet address bar
Whiteboard: [fxdroid]
See Also: → 1879380
Severity: -- → N/A

Setting toolbar redesign's Nightly blockers to priority P1.

Priority: -- → P1

Note: as a temporary idea, maybe we can move forward with the assumption that we can just always show the nav bar (rather than hiding it when in landscape mode). Instead, we could just switch the Toolbar container to a horizontal layout instead of a vertical layout (e.g. when in landscape mode or on a tablet).

(The goal of this idea would be to prevent us from having to deal with each of the buttons in the address bar individually, depending on different orientations or edge cases - because they would simply always be present in the nav bar itself)

We could always refine the Toolbar to be more adaptive to landscape & tablet layouts later, if this version of the nav bar seems overkill in practice.

Assignee: nobody → skhan
Status: NEW → ASSIGNED

Mike a [:mavduevskiy] is already working on this so will un-assign myself

Assignee: skhan → mavduevskiy
Pushed by mavduevskiy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eca9e8f188a3 Change menu button visibility based on that of navbar r=android-reviewers,petru

Backed out for causing Fenix failures

Backout link

Push with failures

Failure log

Flags: needinfo?(mavduevskiy)
Attachment #9403918 - Attachment description: Bug 1893527 - Change menu button visibility based on that of navbar → WIP: Bug 1893527 - Change menu button visibility based on that of navbar
Attachment #9403918 - Attachment description: WIP: Bug 1893527 - Change menu button visibility based on that of navbar → Bug 1893527 - Change menu button visibility based on that of navbar
Pushed by mavduevskiy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c94f26161d8 Change menu button visibility based on that of navbar r=android-reviewers,petru
Regressions: 1902647

Backed out for causing bug 1902647

[task 2024-06-14T12:03:10.666Z] RunTests
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z]  Smart Flank cache hit: 0% (0 / 5)
[task 2024-06-14T12:03:10.666Z]   Shard times: 240s, 360s
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z]   5 tests / 2 shards
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z]   1 matrix ids created in 0m 3s
[task 2024-06-14T12:03:10.666Z]   Raw results will be stored in your GCS bucket at [https://console.developers.google.com/storage/browser/fenix_test_artifacts/2024-06-14_11-59-04.566370_fKAA]
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z] Matrices webLink
[task 2024-06-14T12:03:10.666Z]   matrix-2u4xhuv5wyi3k https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.80a1a071cfb2770e/matrices/5018921326187919007/details
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z]   3m 37s matrix-2u4xhuv5wyi3k FINISHED
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z]   CostReport
[task 2024-06-14T12:03:10.666Z]   Virtual devices
[task 2024-06-14T12:03:10.666Z]     $0.07 for 4m
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z] MatrixResultsReport
[task 2024-06-14T12:03:10.666Z]   0 / 1 (0.00%)
[task 2024-06-14T12:03:10.666Z]   1 matrices failed
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z] ???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????
[task 2024-06-14T12:03:10.666Z] ? OUTCOME ?      MATRIX ID       ? APP NAME ?  TEST FILE NAME  ?       TEST AXIS VALUE        ?         TEST DETAILS          ?
[task 2024-06-14T12:03:10.666Z] ???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????
[task 2024-06-14T12:03:10.666Z] ? failure ? matrix-2u4xhuv5wyi3k ? app.apk  ? android-test.apk ? Pixel2.arm-30-en_US-portrait ? 2 test cases failed, 3 passed ?
[task 2024-06-14T12:03:10.666Z] ???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????
[task 2024-06-14T12:03:10.666Z] More details are available at:
[task 2024-06-14T12:03:10.666Z] https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.80a1a071cfb2770e/matrices/5018921326187919007/details
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z] Matrices webLink
[task 2024-06-14T12:03:10.666Z]   matrix-2u4xhuv5wyi3k https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.80a1a071cfb2770e/matrices/5018921326187919007/details
[task 2024-06-14T12:03:10.666Z] Actual shard times:
[task 2024-06-14T12:03:10.666Z]   Shard 0: Expected: 0s, Actual: 16s, Diff: 16s
[task 2024-06-14T12:03:10.666Z]   Shard 1: Expected: 0s, Actual: 87s, Diff: 87s
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z] 
[task 2024-06-14T12:03:10.666Z] Command /usr/bin/java -jar /builds/worker/test-tools/flank.jar android run --config ./automation/taskcluster/androidTest/flank-arm-start-test.yml --app /builds/worker/checkouts/gecko/mobile/android/fenix/app.apk --local-result-dir /builds/worker/artifacts/results --project moz-fenix --client-details matrixLabel=autoland --test /builds/worker/checkouts/gecko/mobile/android/fenix/android-test.apk failed with exit code 10
[task 2024-06-14T12:03:10.718Z] TEST-UNEXPECTED-FAIL | org.mozilla.fenix.ui.HistoryTest#verifyHistoryMenuWithHistoryItemsTest | androidx.test.espresso.PerformException: Error performing 'single click' on view 'view.getContentDescription() is "Menu"'.
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.PerformException$Builder.build(PerformException.java:1)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.base.PerformExceptionHandler.handleSafely(PerformExceptionHandler.java:8)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.base.PerformExceptionHandler.handleSafely(PerformExceptionHandler.java:9)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.base.DefaultFailureHandler$TypedFailureHandler.handle(DefaultFailureHandler.java:4)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.base.DefaultFailureHandler.handle(DefaultFailureHandler.java:5)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.ViewInteraction.waitForAndHandleInteractionResults(ViewInteraction.java:8)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.ViewInteraction.desugaredPerform(ViewInteraction.java:11)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.ViewInteraction.perform(ViewInteraction.java:8)
[task 2024-06-14T12:03:10.718Z]  at org.mozilla.fenix.ui.robots.BrowserRobot$Transition.openThreeDotMenu(BrowserRobot.kt:1070)
[task 2024-06-14T12:03:10.718Z]  at org.mozilla.fenix.ui.HistoryTest.verifyHistoryMenuWithHistoryItemsTest(HistoryTest.kt:65)
[task 2024-06-14T12:03:10.718Z]  ... 54 trimmed
[task 2024-06-14T12:03:10.718Z] Caused by: java.lang.RuntimeException: Action will not be performed because the target view does not match one or more of the following constraints:
[task 2024-06-14T12:03:10.718Z] (view has effective visibility <VISIBLE> and view.getGlobalVisibleRect() covers at least <90> percent of the view's area)
[task 2024-06-14T12:03:10.718Z] Target view: "AppCompatImageView{id=2131297026, res-name=icon, desc=Menu, visibility=VISIBLE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, layout-params=android.widget.FrameLayout$LayoutParams@YYYYYY, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}"
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.ViewInteraction.doPerform(ViewInteraction.java:20)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.ViewInteraction.-$$Nest$mdoPerform(Unknown Source:0)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.ViewInteraction$1.call(ViewInteraction.java:7)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.ViewInteraction$1.call(ViewInteraction.java:1)
[task 2024-06-14T12:03:10.718Z]  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[task 2024-06-14T12:03:10.718Z]  at android.os.Handler.handleCallback(Handler.java:938)
[task 2024-06-14T12:03:10.718Z]  at android.os.Handler.dispatchMessage(Handler.java:99)
[task 2024-06-14T12:03:10.718Z]  at android.os.Looper.loop(Looper.java:223)
[task 2024-06-14T12:03:10.718Z]  at android.app.ActivityThread.main(ActivityThread.java:7656)
[task 2024-06-14T12:03:10.718Z]  at java.lang.reflect.Method.invoke(Native Method)
[task 2024-06-14T12:03:10.718Z]  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
[task 2024-06-14T12:03:10.718Z]  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
[task 2024-06-14T12:03:10.718Z] 
[task 2024-06-14T12:03:10.718Z]     
[task 2024-06-14T12:03:10.718Z] TEST-UNEXPECTED-FAIL | org.mozilla.fenix.ui.HistoryTest#noHistoryInPrivateBrowsingTest | androidx.test.espresso.PerformException: Error performing 'single click' on view 'view.getContentDescription() is "Menu"'.
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.PerformException$Builder.build(PerformException.java:1)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.base.PerformExceptionHandler.handleSafely(PerformExceptionHandler.java:8)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.base.PerformExceptionHandler.handleSafely(PerformExceptionHandler.java:9)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.base.DefaultFailureHandler$TypedFailureHandler.handle(DefaultFailureHandler.java:4)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.base.DefaultFailureHandler.handle(DefaultFailureHandler.java:5)
[task 2024-06-14T12:03:10.718Z]  at androidx.test.espresso.ViewInteraction.waitForAndHandleInteractionResults(ViewInteraction.java:8)
[task 2024-06-14T12:03:10.719Z]  at androidx.test.espresso.ViewInteraction.desugaredPerform(ViewInteraction.java:11)
[task 2024-06-14T12:03:10.719Z]  at androidx.test.espresso.ViewInteraction.perform(ViewInteraction.java:8)
[task 2024-06-14T12:03:10.719Z]  at org.mozilla.fenix.ui.robots.BrowserRobot$Transition.openThreeDotMenu(BrowserRobot.kt:1070)
[task 2024-06-14T12:03:10.719Z]  at org.mozilla.fenix.ui.HistoryTest.noHistoryInPrivateBrowsingTest(HistoryTest.kt:412)
[task 2024-06-14T12:03:10.719Z]  ... 54 trimmed
[task 2024-06-14T12:03:10.719Z] Caused by: java.lang.RuntimeException: Action will not be performed because the target view does not match one or more of the following constraints:
[task 2024-06-14T12:03:10.719Z] (view has effective visibility <VISIBLE> and view.getGlobalVisibleRect() covers at least <90> percent of the view's area)
[task 2024-06-14T12:03:10.719Z] Target view: "AppCompatImageView{id=2131297026, res-name=icon, desc=Menu, visibility=VISIBLE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, layout-params=android.widget.FrameLayout$LayoutParams@YYYYYY, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}"
[task 2024-06-14T12:03:10.719Z]  at androidx.test.espresso.ViewInteraction.doPerform(ViewInteraction.java:20)
[task 2024-06-14T12:03:10.719Z]  at androidx.test.espresso.ViewInteraction.-$$Nest$mdoPerform(Unknown Source:0)
[task 2024-06-14T12:03:10.719Z]  at androidx.test.espresso.ViewInteraction$1.call(ViewInteraction.java:7)
[task 2024-06-14T12:03:10.719Z]  at androidx.test.espresso.ViewInteraction$1.call(ViewInteraction.java:1)
[task 2024-06-14T12:03:10.719Z]  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[task 2024-06-14T12:03:10.719Z]  at android.os.Handler.handleCallback(Handler.java:938)
[task 2024-06-14T12:03:10.719Z]  at android.os.Handler.dispatchMessage(Handler.java:99)
[task 2024-06-14T12:03:10.719Z]  at android.os.Looper.loop(Looper.java:223)
[task 2024-06-14T12:03:10.719Z]  at android.app.ActivityThread.main(ActivityThread.java:7656)
[task 2024-06-14T12:03:10.719Z]  at java.lang.reflect.Method.invoke(Native Method)
[task 2024-06-14T12:03:10.719Z]  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
[task 2024-06-14T12:03:10.719Z]  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
[task 2024-06-14T12:03:10.719Z] 
[task 2024-06-14T12:03:10.719Z]     
[task 2024-06-14T12:03:10.719Z] ╔════════════════════════════════════════════════════════════════════════╤═════════╤═══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════╗
[task 2024-06-14T12:03:10.719Z] ║ UI Test                                                                │ Outcome │ Details                                                                                                                                                                   ║
[task 2024-06-14T12:03:10.719Z] ╟────────────────────────────────────────────────────────────────────────┼─────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╢
[task 2024-06-14T12:03:10.719Z] ║ org.mozilla.fenix.ui.HistoryTest#verifyHistoryMenuWithHistoryItemsTest │ Failure │ androidx.test.espresso.PerformException: Error performing 'single click' on view 'view.getContentDescription() is "Menu"'.                                                ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.PerformException$Builder.build(PerformException.java:1)                                                                                        ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.base.PerformExceptionHandler.handleSafely(PerformExceptionHandler.java:8)                                                                      ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.base.PerformExceptionHandler.handleSafely(PerformExceptionHandler.java:9)                                                                      ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.base.DefaultFailureHandler$TypedFailureHandler.handle(DefaultFailureHandler.java:4)                                                            ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.base.DefaultFailureHandler.handle(DefaultFailureHandler.java:5)                                                                                ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction.waitForAndHandleInteractionResults(ViewInteraction.java:8)                                                                     ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction.desugaredPerform(ViewInteraction.java:11)                                                                                      ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction.perform(ViewInteraction.java:8)                                                                                                ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at org.mozilla.fenix.ui.robots.BrowserRobot$Transition.openThreeDotMenu(BrowserRobot.kt:1070)                                                                            ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at org.mozilla.fenix.ui.HistoryTest.verifyHistoryMenuWithHistoryItemsTest(HistoryTest.kt:65)                                                                             ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  ... 54 trimmed                                                                                                                                                           ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │ Caused by: java.lang.RuntimeException: Action will not be performed because the target view does not match one or more of the following constraints:                      ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │ (view has effective visibility <VISIBLE> and view.getGlobalVisibleRect() covers at least <90> percent of the view's area)                                                 ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │ Target view: "AppCompatImageView{id=2131297026, res-name=icon, desc=Menu, visibility=VISIBLE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=t ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │ rue, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, layout-params=android.widget.FrameLayout$Lay ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │ outParams@YYYYYY, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}"                                                                    ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction.doPerform(ViewInteraction.java:20)                                                                                             ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction.-$$Nest$mdoPerform(Unknown Source:0)                                                                                           ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction$1.call(ViewInteraction.java:7)                                                                                                 ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction$1.call(ViewInteraction.java:1)                                                                                                 ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at java.util.concurrent.FutureTask.run(FutureTask.java:266)                                                                                                              ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at android.os.Handler.handleCallback(Handler.java:938)                                                                                                                   ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at android.os.Handler.dispatchMessage(Handler.java:99)                                                                                                                   ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at android.os.Looper.loop(Looper.java:223)                                                                                                                               ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at android.app.ActivityThread.main(ActivityThread.java:7656)                                                                                                             ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at java.lang.reflect.Method.invoke(Native Method)                                                                                                                        ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)                                                                                     ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)                                                                                                          ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │                                                                                                                                                                           ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │                                                                                                                                                                           ║
[task 2024-06-14T12:03:10.719Z] ╟────────────────────────────────────────────────────────────────────────┼─────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╢
[task 2024-06-14T12:03:10.719Z] ║ org.mozilla.fenix.ui.HistoryTest#noHistoryInPrivateBrowsingTest        │ Failure │ androidx.test.espresso.PerformException: Error performing 'single click' on view 'view.getContentDescription() is "Menu"'.                                                ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.PerformException$Builder.build(PerformException.java:1)                                                                                        ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.base.PerformExceptionHandler.handleSafely(PerformExceptionHandler.java:8)                                                                      ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.base.PerformExceptionHandler.handleSafely(PerformExceptionHandler.java:9)                                                                      ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.base.DefaultFailureHandler$TypedFailureHandler.handle(DefaultFailureHandler.java:4)                                                            ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.base.DefaultFailureHandler.handle(DefaultFailureHandler.java:5)                                                                                ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction.waitForAndHandleInteractionResults(ViewInteraction.java:8)                                                                     ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction.desugaredPerform(ViewInteraction.java:11)                                                                                      ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction.perform(ViewInteraction.java:8)                                                                                                ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at org.mozilla.fenix.ui.robots.BrowserRobot$Transition.openThreeDotMenu(BrowserRobot.kt:1070)                                                                            ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at org.mozilla.fenix.ui.HistoryTest.noHistoryInPrivateBrowsingTest(HistoryTest.kt:412)                                                                                   ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  ... 54 trimmed                                                                                                                                                           ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │ Caused by: java.lang.RuntimeException: Action will not be performed because the target view does not match one or more of the following constraints:                      ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │ (view has effective visibility <VISIBLE> and view.getGlobalVisibleRect() covers at least <90> percent of the view's area)                                                 ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │ Target view: "AppCompatImageView{id=2131297026, res-name=icon, desc=Menu, visibility=VISIBLE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=t ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │ rue, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, layout-params=android.widget.FrameLayout$Lay ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │ outParams@YYYYYY, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}"                                                                    ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction.doPerform(ViewInteraction.java:20)                                                                                             ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction.-$$Nest$mdoPerform(Unknown Source:0)                                                                                           ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction$1.call(ViewInteraction.java:7)                                                                                                 ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at androidx.test.espresso.ViewInteraction$1.call(ViewInteraction.java:1)                                                                                                 ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at java.util.concurrent.FutureTask.run(FutureTask.java:266)                                                                                                              ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at android.os.Handler.handleCallback(Handler.java:938)                                                                                                                   ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at android.os.Handler.dispatchMessage(Handler.java:99)                                                                                                                   ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at android.os.Looper.loop(Looper.java:223)                                                                                                                               ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at android.app.ActivityThread.main(ActivityThread.java:7656)                                                                                                             ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at java.lang.reflect.Method.invoke(Native Method)                                                                                                                        ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)                                                                                     ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)                                                                                                          ║
[task 2024-06-14T12:03:10.719Z] ║                                                                        │         │                                                                                                                                                                           ║
[task 2024-06-14T12:03:10.725Z] ║                                                                        │         │                                                                                                                                                                           ║
[task 2024-06-14T12:03:10.725Z] ╚════════════════════════════════════════════════════════════════════════╧═════════╧═══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════╝
[task 2024-06-14T12:03:10.725Z] Command ./automation/taskcluster/androidTest/parse-ui-test-fromfile.py --results /builds/worker/artifacts/results failed with exit code 2
[taskcluster 2024-06-14 12:03:11.051Z] === Task Finished ===
[taskcluster 2024-06-14 12:03:13.655Z] Unsuccessful task run with exit code: 10 completed in 391.252 seconds
Pushed by mavduevskiy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ad552977cf1f Change menu button visibility based on that of navbar r=android-reviewers,petru

https://hg.mozilla.org/mozilla-central/rev/ad552977cf1f

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch

missing this behaviour for the home page

Status: RESOLVED → REOPENED
Flags: needinfo?(mavduevskiy)
Resolution: FIXED → ---
Attachment #9408522 - Attachment description: WIP: Bug 1893527 - Fix menu visibility in landscape/tablet when navbar is on → Bug 1893527 - Fix menu visibility in landscape/tablet when navbar is on
Pushed by mavduevskiy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7907a8fc2172 Fix menu visibility in landscape/tablet when navbar is on r=android-reviewers,Roger

https://hg.mozilla.org/mozilla-central/rev/7907a8fc2172

Status: REOPENED → RESOLVED
Closed: 8 months ago → 8 months ago
status-firefox129: affected → fixed
Resolution: --- → FIXED
See Also: → 1909881
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: