1893553 - Perma cctools-port: ./../code-sign-blobs/blob.h:185:60: error: no member named 'clone' in 'Security::BlobCore'

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Mike Hommey [:glandium]]

[task 2024-04-25T20:51:29.148Z] In file included from macho_dylib_file.cpp:46:
[task 2024-04-25T20:51:29.148Z] In file included from ./../code-sign-blobs/superblob.h:7:
[task 2024-04-25T20:51:29.148Z] ./../code-sign-blobs/blob.h:185:60: error: no member named 'clone' in 'Security::BlobCore'
[task 2024-04-25T20:51:29.148Z]   185 |         { assert(validateBlob()); return specific(this->BlobCore::clone());     }
[task 2024-04-25T20:51:29.148Z]       |                                                         ~~~~~~~~~~^

Comment 1

[Mike Hommey [:glandium]]

The code was already buggy, but this wasn't caught by clang until https://github.com/llvm/llvm-project/pull/84050.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1893553 - Remove unused broken code from cctools.

The base class doesn't have a clone member function, so the code was
never valid. As it was unused, that didn't cause problems until clang
caught this earlier than instantiation in
https://github.com/llvm/llvm-project/pull/84050

Submitted upstream as https://github.com/tpoechtrager/cctools-port/pull/148

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a009318c4573
Remove unused broken code from cctools. r=firefox-build-system-reviewers,sergesanspaille,nalexander

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/a009318c4573