1893661 - Revamped sidebar buttons are displaying with a repeated background, wrong background color

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect)

Description

[Hanna Jones [:hjones]]

Attachment: bad button display in the revamped sidebar

Looks like this is due to an issue with some recent moz-button changes interpreting white space as a label, and styling these buttons as if they have a label. Because the white space is likely coming from how the code is formatted, we should address this in moz-button.

Comment 1

[Hanna Jones [:hjones]]

Attachment: Bug 1893661 - fix moz-button icon buttons when label is empty string r=kcochrane,#recomp-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1858812

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed101e266315
fix moz-button icon buttons when label is empty string r=kcochrane,reusable-components-reviewers,mstriemer

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc6018dda9ff
Backed out changeset ed101e266315 for causing mochitest failures on test_moz_button.html CLOSED TREE

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on test_moz_button.html

Backout link

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12441434bca1
fix moz-button icon buttons when label is empty string r=kcochrane,reusable-components-reviewers,mstriemer

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing OS X mochitests failures in test_moz_button.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_moz_button.html | backgroundColor should be --button-background-color - got "rgba(21, 20, 26, 0.14000000059604645)", expected "rgba(21, 20, 26, 0.07000000029802322)"

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4459d106a011
fix moz-button icon buttons when label is empty string r=kcochrane,reusable-components-reviewers,mstriemer

Comment 9

[Norisz Fay [:noriszfay]]

Backed out for causing failures on test_moz_button.html

Backout link

Push with failures

Failure log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2bdce8f6fdc
fix moz-button icon buttons when label is empty string r=kcochrane,reusable-components-reviewers,mstriemer

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a2bdce8f6fdc