1893731 - SVG animation is not rendering

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[leeroyjenkins176]

Attachment: chart.svg

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:125.0) Gecko/20100101 Firefox/125.0

Steps to reproduce:

CSS animation
@keyframes chart {
from { width: 0px }
to { width: 606px }
}
Applied to a <rect> element located inside a <clipPath>. After a few seconds/milliseconds from the start, the animation stops rendering. You can only resume rendering by clicking the document with the mouse.

Comment 1

[leeroyjenkins176]

Attachment: chrome.mp4

Comment 2

[leeroyjenkins176]

Attachment: firefox.mp4

Comment 3

[Timothy Nikkel (:tnikkel)]

Not a recent regression goes back to at least 2019. Before that we don't even try to animate, we just show the whole graph from the start, presumably we implemented something to do that. The range I get for that is this

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=29bdbbe89264b91d1bd4205c45536c9222a8d6ee&tochange=257f2c96cef502a1d674df56c8e39d76d8ed4d89

Comment 4

[Alice0775 White]

(In reply to Timothy Nikkel (:tnikkel) from comment #3)

Not a recent regression goes back to at least 2019. Before that we don't even try to animate, we just show the whole graph from the start, presumably we implemented something to do that. The range I get for that is this

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=29bdbbe89264b91d1bd4205c45536c9222a8d6ee&tochange=257f2c96cef502a1d674df56c8e39d76d8ed4d89

Narrowed:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2ad581fafc85ab939d75f7aa1a2f901f45ecb113&tochange=21b3ac9c491755466306d68e1e198a6891c0e561

Comment 5

[Timothy Nikkel (:tnikkel)]

Thanks for narrowing that down.

I don't think I would call this bug regressed by that. That bug is what allows the animation to even try to animate, before that we didn't even try to animate it.

Comment 6

[Timothy Nikkel (:tnikkel)]

In a profile I see that all the other animations in the document are listed (opacity, axis-x axis-y) but not the animation for drawing the content of the chart (chart). The chart animation is on the clippath that is applied to the chart content, as opposed to on the content itself like the other animations.

Flipping dom.animations.offscreen-throttling does not have an affect.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: reduced test-case

Comment 8

[Robert Longson [:longsonr]]

Attachment: Bug 1893731 - invalidate rendering observers when SVG geometry styles change r=emilio

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1893731 - Allow posting restyles from DidSetComputedStyle / the post-traversal. r=longsonr,#style

This doesn't change behavior as is but prevents an assertion with the
other proposed patch.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50a09d96ee0d
Allow posting restyles from DidSetComputedStyle / the post-traversal. r=longsonr

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e9ba14c08df
invalidate rendering observers when SVG geometry styles change r=emilio

Comment 13

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/50a09d96ee0d
https://hg.mozilla.org/mozilla-central/rev/6e9ba14c08df