1893737 - Dailymotion captions no longer appear on PiP window

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[kpatenio]

STR:

1. Open a Dailymotion video with captions. Ex. https://www.dailymotion.com/video/x86xb3b
2. Enable captions on the video
3. Open PiP window

Expected:

• PiP window should have captions shown on the video

Actual:

• There are no captions

Notes:

• We already have a Dailymotion wrapper, but the wrapper no longer works. I suspect that this has something to do with videos now being loaded in an iframe, and the video src url does not match what's found in the overrides. If that is the case, this is similar to Bug 1825105 and Bug 1890807.

Comment 1

[kpatenio]

Looking back, I think we can utilize a div.player div.subtitles element in the page to read the subtitles text content. Doing so requires these changes:

1. Updating the container element. Looks like we can modify the query to read a div with a class player. The element is a parent of the video.
2. Updating the text node list to read the contents of a div with a class subtitles.

Other notes:

• The subtitles rendered on the PiP window should disappear if none are displayed on the original video. This includes whenever there's no text to render, or when cc is disabled.

Comment 2

[kpatenio]

Resolving as FIXED, addressed by patch for Bug 1920315.

Comment 3

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-04-26 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 135.0a1 and Firefox 134.0b2 on Windows 10, macOS 14, Ubuntu 22.