Open Bug 1893763 Opened 2 months ago Updated 1 month ago

readerview.css fails stylelint: Unexpected empty block

Categories

(Fenix :: General, defect)

All
Android
defect

Tracking

(Not tracked)

People

(Reporter: gbrown, Unassigned, NeedInfo)

References

Details

Steps to reproduce

  1. Remove the exclusion in .stylelintignore for mobile/android/android-components/components/feature/readerview/src/main/assets/extensions/readerview/readerview.css
  2. Run mach lint --linter=stylelint -- mobile/android/android-components/components/feature/readerview/src/main/assets/extensions/readerview/readerview.css

Expected behavior

No lint errors.

Actual behavior

$ ./mach lint --linter=stylelint -- mobile/android/android-components/components/feature/readerview/src/main/assets/extensions/readerview/readerview.css
/home/gbrown/src/mobile/android/android-components/components/feature/readerview/src/main/assets/extensions/readerview/readerview.css
  306:36  error  Unexpected empty block  block-no-empty (stylelint)

✖ 1 problem (1 error, 0 warnings, 0 fixed)

Any additional information?

Discussed in https://phabricator.services.mozilla.com/D207207. It looks like this code has "always" been this way: https://github.com/mozilla-mobile/android-components/commit/7a38090a09cc2d9d043760ed7de9ca79e00fc86f

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jboek)
You need to log in before you can comment on or make changes to this bug.