1893871 - Partial selection starting from beginning of address includes the https:// protocol when untrimmed

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Kestrel]

Attachment: Protocol unexpectedly added to partial selection

STR:

1. Visit https://bugzilla.mozilla.org.
2. Select the "bugzilla" subdomain in the address.

Expected:
Only "bugzilla" is selected.

Actual:
The protocol is added to the selection, resulting in "https://bugzilla".

Only happens when the first character in the address is selected, selecting "ugzilla" works as expected.

Does not happen on Chrome.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=40423991307494c32432a8410d02b2751e124a97&tochange=96d4e09e124215e9af45acf8dc6507e7a9fcf239

Regressed by Bug 1848715.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:mak, since you are the author of the regressor, bug 1848715, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Marco Bonardo [:mak]]

This was actually on purpose, as one may be copying the beginning of the url, like just the domain for example, or a partial path.

The behavior in Chrome apparently differs depending on the selection being a trimmed url or not, as if I select "bugzilla.org" or just "bugzilla" it's doing different selection. That's not really discoverable though, so the preferred behavior is debatable.
I can see the reason for their behavior, we'll evaluate if it's worth it.

Comment 3

[Kestrel]

It makes no sense to include the protocol for something that does not resemble an address. The "https://bugzilla" selection in this case has no practical value and deleting it so the subdomain can be changed needlessly removes the protocol. The user expects to be able to select a subdomain and copy/edit it like before without untrim interference.

Comment 4

[Marco Bonardo [:mak]]

Editing the subdomain is indeed a valid use case. That is likely the reason they differenciated the behavior.
It's unfortunate the reason for that different behavior is quite obscure for the non technical user.

Comment 5

[Haik Aftandilian [:haik]]

@Marco, any decision on addressing this in 127?

Comment 6

[Marco Bonardo [:mak]]

Yes, we should fix it, we can use URIFixup here.
Though it's not super important for the fix to be in 127, as the change is nightly only. We'll do asap.

Comment 7

[Marco Bonardo [:mak]]

Attachment: Bug 1893871 - When untrimming the URL adjust partial selection depending on whether the selected text is a valid URL. r=dao

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa4cc8bbfe9c
When untrimming the URL adjust partial selection depending on whether the selected text is a valid URL. r=dao

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/aa4cc8bbfe9c

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mak, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-04-28 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 128.0a1 on Windows 10, macOS 12, Ubuntu 22.