Closed Bug 1893985 Opened 2 months ago Closed 1 month ago

Remove incorrect and unnecessary strict statement from FxAccountsProfileClient.sys.mjs

Categories

(Firefox :: Firefox Accounts, task)

task

Tracking

()

RESOLVED FIXED
127 Branch
Tracking Status
firefox127 --- fixed

People

(Reporter: standard8, Assigned: danielmazarakos, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

I noticed that FxAccountsProfileClient.sys.mjs has a redundant and incorrect strict mode statement.

The statement is "use strict;"; which should be "use strict";.

However, since that file is now an ES module, the strict mode statement is redundant and that line can simply be removed.

Removed redundant and incorrect "use strict" statement from FxAccountsProfileClient.sys.mjs

changed services/fxaccounts/FxAccountsProfileClient.sys.mjs

Assignee: nobody → danielmazarakos
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88fbb823f9f4
Remove incorrect and unnecessary strict statement from FxAccountsProfileClient.sys.mjs r=markh

Hi I fixed the bug unless there is anything else wrong this listing can be closed.

Flags: needinfo?(standard8)

(In reply to endington543 from comment #3)

Hi I fixed the bug unless there is anything else wrong this listing can be closed.

Thank you, the fix has landed on autoland where it gets tested via our continuous integration set-up, along with other changes. If all goes well, then sometime within the next 24 hours it will be merged to central, at which point the bug will automatically get marked as fixed.

Flags: needinfo?(standard8)
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: