1894061 - Session restore telemetry can_load extra isn't working correctly and causes error console spam

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P1)

Description

[:Gijs (he/him)]

I've recently started seeing Extra properties should have string values. in my browser console after startup (on local nightly builds - possibly also distributed nightly builds but I can't recall off-hand).

That's coming from https://searchfox.org/mozilla-central/rev/2e7374599f4020d0490ec8c5e877c179c9e153c9/toolkit/components/telemetry/core/TelemetryEvent.cpp#848 so it's a telemetry event where some of the extra bits are invalid.

Standard8 did some digging on matrix:

Gijs: I see it as well. I quickly added debug and the first three params to RecordEvent are session_restore backup_can_be_loaded session_file
Gijs: https://searchfox.org/mozilla-central/rev/2e7374599f4020d0490ec8c5e877c179c9e153c9/browser/components/sessionstore/SessionFile.sys.mjs#358 maybe? That's a boolean, not a boolean string...
Its definitely the can_load key
Oh, that's subtle

Kelly, would you mind taking a look?

Comment 1

[:Gijs (he/him)]

(looks like it should be (!corrupted).toString() instead of !corrupted.toString(), maybe?)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1874742

Comment 3

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1894061 - Resolving 'can_load' extra key error for session restore telemetry causing error console spam r?Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5502377f2629
Resolving 'can_load' extra key error for session restore telemetry causing error console spam r=Gijs,sessionstore-reviewers,sfoster

Comment 5

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/5502377f2629

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kcochrane, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox126 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Kelly Cochrane [:kcochrane]]

Comment on attachment 9399227 [details]
Bug 1894061 - Resolving 'can_load' extra key error for session restore telemetry causing error console spam r?Gijs

Beta/Release Uplift Approval Request

• User impact if declined: console error spam can occur for session restore telemetry
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Description
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small syntax fix
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9399227 [details]
Bug 1894061 - Resolving 'can_load' extra key error for session restore telemetry causing error console spam r?Gijs

Approved for 126.0b9

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ed553c62ace

Comment 10

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to replicate the issue on an affected Firefox Nightly build from 2024-04-29, using macOS 12.6.6, while following the steps described in Comment 0.
Verified as fixed on Firefox Beta 126.0b9, build ID 20240501222611 (Treeherder build) and on Firefox Nightly 127.0a1, build ID 20240502091633, using macOS 12.6.6, Windows 11 and Ubuntu 22.04.
"Extra properties should have string values." is no longer displayed in the browser console after launching the browser.
If there are any other scenario that should be checked here, please let us know! Thanks.