1894143 - [rustc 1.79] error: non-local `impl` definition, they should be avoided as they go against expectation

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mike Hommey [:glandium]]

[task 2024-04-30T00:30:58.281Z] 00:30:58    ERROR -  error: non-local `impl` definition, they should be avoided as they go against expectation
[task 2024-04-30T00:30:58.281Z] 00:30:58     INFO -     --> gfx/wr/webrender_api/src/lib.rs:108:91
[task 2024-04-30T00:30:58.281Z] 00:30:58     INFO -      |
[task 2024-04-30T00:30:58.281Z] 00:30:58     INFO -  108 | #[derive(Clone, Copy, Debug, Default, Eq, MallocSizeOf, PartialEq, Hash, Ord, PartialOrd, PeekPoke)]
[task 2024-04-30T00:30:58.282Z] 00:30:58     INFO -      |                                                                                           ^^^^^^^^
[task 2024-04-30T00:30:58.282Z] 00:30:58     INFO -      |
[task 2024-04-30T00:30:58.282Z] 00:30:58     INFO -      = help: move this `impl` block outside the of the current constant `_DERIVE_peek_poke_Poke_FOR_IdNamespace`
[task 2024-04-30T00:30:58.283Z] 00:30:58     INFO -      = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
[task 2024-04-30T00:30:58.283Z] 00:30:58     INFO -      = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
[task 2024-04-30T00:30:58.283Z] 00:30:58     INFO -      = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
[task 2024-04-30T00:30:58.284Z] 00:30:58     INFO -      = note: the derive macro `PeekPoke` may come from an old version of the `peek_poke_derive` crate, try updating your dependency with `cargo update -p peek_poke_derive`
[task 2024-04-30T00:30:58.284Z] 00:30:58     INFO -      = note: `-D non-local-definitions` implied by `-D warnings`
[task 2024-04-30T00:30:58.284Z] 00:30:58     INFO -      = help: to override `-D warnings` add `#[allow(non_local_definitions)]`
[task 2024-04-30T00:30:58.285Z] 00:30:58     INFO -      = note: this error originates in the derive macro `PeekPoke` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2024-04-30T00:30:58.285Z] 00:30:58    ERROR -  error: non-local `impl` definition, they should be avoided as they go against expectation
[task 2024-04-30T00:30:58.285Z] 00:30:58     INFO -     --> gfx/wr/webrender_api/src/lib.rs:118:89
[task 2024-04-30T00:30:58.285Z] 00:30:58     INFO -      |
[task 2024-04-30T00:30:58.286Z] 00:30:58     INFO -  118 | #[derive(Clone, Copy, Debug, Deserialize, Eq, Hash, MallocSizeOf, PartialEq, Serialize, PeekPoke)]
[task 2024-04-30T00:30:58.286Z] 00:30:58     INFO -      |                                                                                         ^^^^^^^^
[task 2024-04-30T00:30:58.286Z] 00:30:58     INFO -      |
[task 2024-04-30T00:30:58.286Z] 00:30:58     INFO -      = help: move this `impl` block outside the of the current constant `_DERIVE_peek_poke_Poke_FOR_DocumentId`
[task 2024-04-30T00:30:58.287Z] 00:30:58     INFO -      = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
[task 2024-04-30T00:30:58.287Z] 00:30:58     INFO -      = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
[task 2024-04-30T00:30:58.287Z] 00:30:58     INFO -      = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
[task 2024-04-30T00:30:58.288Z] 00:30:58     INFO -      = note: the derive macro `PeekPoke` may come from an old version of the `peek_poke_derive` crate, try updating your dependency with `cargo update -p peek_poke_derive`
[task 2024-04-30T00:30:58.288Z] 00:30:58     INFO -      = note: this error originates in the derive macro `PeekPoke` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2024-04-30T00:30:58.288Z] 00:30:58    ERROR -  error: non-local `impl` definition, they should be avoided as they go against expectation
[task 2024-04-30T00:30:58.289Z] 00:30:58     INFO -     --> gfx/wr/webrender_api/src/lib.rs:148:89
[task 2024-04-30T00:30:58.289Z] 00:30:58     INFO -      |
[task 2024-04-30T00:30:58.289Z] 00:30:58     INFO -  148 | #[derive(Clone, Copy, Debug, Deserialize, Eq, Hash, MallocSizeOf, PartialEq, Serialize, PeekPoke)]
[task 2024-04-30T00:30:58.289Z] 00:30:58     INFO -      |                                                                                         ^^^^^^^^
[task 2024-04-30T00:30:58.289Z] 00:30:58     INFO -      |
[task 2024-04-30T00:30:58.290Z] 00:30:58     INFO -      = help: move this `impl` block outside the of the current constant `_DERIVE_peek_poke_Poke_FOR_PipelineId`
[task 2024-04-30T00:30:58.290Z] 00:30:58     INFO -      = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
[task 2024-04-30T00:30:58.291Z] 00:30:58     INFO -      = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
[task 2024-04-30T00:30:58.291Z] 00:30:58     INFO -      = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
[task 2024-04-30T00:30:58.291Z] 00:30:58     INFO -      = note: the derive macro `PeekPoke` may come from an old version of the `peek_poke_derive` crate, try updating your dependency with `cargo update -p peek_poke_derive`
[task 2024-04-30T00:30:58.291Z] 00:30:58     INFO -      = note: this error originates in the derive macro `PeekPoke` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2024-04-30T00:30:58.292Z] 00:30:58    ERROR -  error: non-local `impl` definition, they should be avoided as they go against expectation

etc.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gw, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1894143 - Update synstructure to 0.13.1.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95ae1f5d6f8d
Update synstructure to 0.13.1. r=nika,supply-chain-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/95ae1f5d6f8d