189433 - configure fail when both --enable-ctl & --enable-default-toolkit=gtk2

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Louie Zhao]

when ./configure --enable-ctl --enable-default-toolkit=gtk2 under Linux and
Solaris, configure will fail:
configure: error: Cannot build ctl without gmodule support in glib.

if enable-ctl, configure will execute checking code which use GLIB_CFLAGS. But
if enable gtk2, GLIB_CONFIG will never got value, thus GLIB_CFLAGS has no value.

Comment 1

[Prabhat Hegde]

One more related issue on Solaris (possibly linux too) with Gnome2.0 installed:

With FT2 enabled, FT2_CFLAGS(which precede GLIB_CFLAGS) cause a wrong(older)
version of glib header to be picked up from /usr/sfw/include as opposed to the
configured Gnome2.0 location of /usr/include/glib2.0. Currently, i've worked
around that as below:

Index: Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/gfx/src/gtk/Makefile.in,v
retrieving revision 1.97
diff -u -r1.97 Makefile.in
--- Makefile.in	28 Dec 2002 01:13:36 -0000	1.97
+++ Makefile.in	21 Jan 2003 18:36:04 -0000
@@ -166,6 +166,11 @@
 CXXFLAGS	+= $(MOZ_GTK_CFLAGS) $(MOZ_GTK2_CFLAGS)
 CFLAGS		+= $(MOZ_GTK_CFLAGS) $(MOZ_GTK2_CFLAGS)
 
+ifdef MOZ_ENABLE_FREETYPE2
+CXXFLAGS	+= $(FT2_CFLAGS)
+CFLAGS		+= $(FT2_CFLAGS)
+endif
+
 ifeq ($(OS_ARCH), Linux)
 DEFINES         += -D_BSD_SOURCE
 endif
@@ -205,7 +210,7 @@
 
 ifdef MOZ_ENABLE_FREETYPE2
 DEFINES         += -DMOZ_ENABLE_FREETYPE2
-INCLUDES        += $(FT2_CFLAGS)
+#INCLUDES        += $(FT2_CFLAGS)
 endif
 
 ifdef MOZ_ENABLE_XPRINT

prabhat

Comment 2

[Jungshik Shin]

from bug 184599 comment #12 :
> Prabhat Hegde: You can delete the CTL checking code for glib in "configure"
> (line 14651 - line 14685) just like mozilla1.2. This checking is for some glib
> on win32, which may not support gmodule. The glib2.0 does support gmodule.


Prabhat, can you put together the above and what you wrote in comment #1?

BTW, is this change gonna make it impossible to build on Win32 with
'enable-ctl'? I want to build with CTL enabled on Win32 as well.

Comment 3

[Roland Mainz]

Over to jshin for now to get some progress with this bug... :)

Comment 4

[Jungshik Shin]

Hey, Roland, you contributed a Solaris  1.6 binary with gtk2 + ctl. Why don't
you attach a patch here? 
 

Comment 5

[Roland Mainz]

Jungshik Shin wrote:
> Hey, Roland, you contributed a Solaris  1.6 binary with gtk2 + ctl. Why don't
> you attach a patch here? 

Uhm... my "patch" simply removes the Glib check in "configure" (e.g. not even
configure.in). It's a workaround which works for Sun's Gnome desktop but I doubt
this counts as a general solution (mhhh... what about adding a hack which
assumes that --enable-default-toolkit="gtk2" simply assumes that glib-2.x is
available, too).

Comment 6

[Louie Zhao]

Attachment: patch v1

This patch may be a work around. We have used it in GNOME enviornment for a
long time. I am not sure whether it'll work OK in other environment. Can
somebody review it? Thanks.

Comment 7

[Roland Mainz]

Comment on attachment 141495 [details] [diff] [review]
patch v1

Louie Zhao:
Can you attach the same patch made with "gdiff -u50", please (that we can see
the surrounding lines), please ?

Comment 8

[Roland Mainz]

Attachment: Original patch, moved to configure.in

Comment 9

[Roland Mainz]

Comment on attachment 141985 [details] [diff] [review]
Original patch, moved to configure.in

Requesting r= ...

Comment 10

[Benjamin Smedberg]

Comment on attachment 141985 [details] [diff] [review]
Original patch, moved to configure.in

I don't understand why this works...

Comment 11

[Roland Mainz]

Benjamin Smedberg wrote:
> (From update of attachment 141985 [details] [diff] [review])
> I don't understand why this works...

AFAIK the libIDL version for GTK1 uses libglib.so, the GTK2 version uses
libglib2.0.so. If I understand  Louie Zhao's patch correctly the usage of the
IDL flag gurantees that there is always a libglib version which works with the
matching toolkit.

Comment 12

[Louie Zhao]

when "--enable-default-toolkit=gtk2", the $GLIB_CFLAGS has no value at lines
around "test "$SUNCTL"". Instead, $LIBIDL_CFLAGS contains the cflags of "glib".

Comment 13

[cls]

Comment on attachment 141985 [details] [diff] [review]
Original patch, moved to configure.in

Oh bah.  The reason GLIB_CFLAGS is empty is because we're explicitly skipping
the glib check when building against gtk2.  If there are parts of the code
which use glib2, we should be explicitly checking for it rather than assuming
the libIDL2 will pull in the right stuff.

Comment 14

[Roland Mainz]

Attachment: Alternate patch

Comment 15

[cls]

Attachment: explicitly check for glib2

This is more of what I had in mind.

Comment 16

[Roland Mainz]

Comment on attachment 142194 [details] [diff] [review]
explicitly check for glib2

Louie, can you tesz the patch, please ?

Comment 17

[Christopher Blizzard (:blizzard)]

gtk2 implies glib2.  That's a pretty safe assumption to make.

Comment 18

[Louie Zhao]

Comment on attachment 142194 [details] [diff] [review]
explicitly check for glib2

I tested it on Linux (with GNOME2.4), it works well.

Comment 19

[Roland Mainz]

Patch checked-in
(http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=MozillaTinderboxAll&branch=HEAD&cvsroot=/cvsroot&date=explicit&mindate=1078811880&maxdate=1078811940&who=cls%25seawood.org),
marking bug as FIXED.