1894331 - Assertion failure: aRate != 0 (Can't create an AudioData with a sample-rate of 0.), at /dom/media/MediaData.cpp:57

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jesse Schwartzentruber (:truber)]

The attached testcase crashes on mozilla-central revision 20240430-0c6cd807867d.

For detailed crash information, see attachment.

To reproduce the issue, you can run the testcase through the "MediaDataDecoder.VP9" gtest. Example STR:

1. Change into objdir/dist/bin of your Firefox build
2. Place attached testcase into objdir, keep the name "vp9cake.webm"
3. Run: GTEST_FILTER=MediaDataDecoder.VP9 MOZ_RUN_GTEST=1 ./firefox -unittest

Comment 1

[Jesse Schwartzentruber (:truber)]

Attachment: Detailed Crash Information

Comment 2

[Jesse Schwartzentruber (:truber)]

Attachment: Testcase

Comment 3

[Jim Mathies [:jimm]]

A re3gression range would be helpful.

Comment 4

[Paul Adenot (:padenot)]

Ashley, see https://pernos.co/debug/mkUhOa9hyFjtTKz0sLFU1w/index.html#f{m[DM4,By9k_,t[Fg,BFz9_,f{e[DAk,SEk_,s{aeDY4YAAA,bAZM,uHRKZ3A,oHRhhLw___/, the if statement to reject the rate is comparing floats, and then we're casting it to integer at the line the trace is at, can you harmonize this?

I think we always want a rate that is zero to error out here. It's not going to be problematic (because it is going to cause an error later in the pipeline), but it's always good to catch errors early.

Comment 5

[az [:az] (back 7/27)]

Attachment: Bug 1894331 - Part 1: Fix audio sample rate sanity check in WebMDemuxer r=padenot

Comment 6

[az [:az] (back 7/27)]

Attachment: Bug 1894331 - Part 2: Add invalid audio sample rate crashtest for WebMDemuxer r=padenot

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62e9e36b1d94
Part 1: Fix audio sample rate sanity check in WebMDemuxer r=padenot
https://hg.mozilla.org/integration/autoland/rev/bcf84db0ae30
Part 2: Add invalid audio sample rate crashtest for WebMDemuxer r=padenot

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing mda assertion failures dist/include/mozilla/Casting.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/b4635d543cea0cc95ce356c7a7f28308a878a310

Push with failures

Failure log -> [4450] Assertion failure: (detail::IsInBounds<From, To>(aFrom)), at /builds/worker/workspace/obj-build/dist/include/mozilla/Casting.h:183

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2d0399cc295
Part 1: Fix audio sample rate sanity check in WebMDemuxer r=padenot
https://hg.mozilla.org/integration/autoland/rev/66547247ad95
Part 2: Add invalid audio sample rate crashtest for WebMDemuxer r=padenot

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c2d0399cc295
https://hg.mozilla.org/mozilla-central/rev/66547247ad95