1894363 - Mispositioned buttons on discord chat.

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: Test-case

Seems a bad interaction between abspos and flexbox.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Ah, it's just the flex item with the <svg> not having the right size...

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Reduced test-case.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

More of an SVG issue with intrinsic sizes if width and height are auto....

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1894363 - Make min size of SVG match nsImageFrame. r=#layout

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: testcase with <embed>

Per review nit, we may need to fix this for <embed> as well, for consistency (since there are code comments at least that imply <embed> and <svg> both use 0, as noted in phab here).

Here's a testcase that I think exercises the bug with embed, as a modified version of your WPT. I haven't tested your patch on it yet, but this testcase is blank in current Nightly and I suspect it might still be blank with your patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/810c65d8b2d3
Make min size of SVG match nsImageFrame. r=dholbert

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46017 for changes under testing/web-platform/tests

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/810c65d8b2d3

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot