1894368 - 41.52 - 20.11% google-maps LastVisualChange / google-maps LastVisualChange (Android) regression on Wed April 17 2024

Status: NEW

(Core :: CSS Transitions and Animations, defect)

Description

[Alex Finder| PTO returning Dec. 8th]

Perfherder has detected a browsertime performance regression from push d06a0d7b341361ec7d0e996636f94a7ebd68b92e. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
42%	google-maps LastVisualChange	android-hw-a51-11-0-aarch64-shippable-qr	warm webrender	443.97 -> 628.32	Before/After
20%	google-maps LastVisualChange	android-hw-a51-11-0-aarch64-shippable-qr	cold webrender	968.30 -> 1,163.04	Before/After

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
54%	espn largestContentfulPaint	windows10-64-shippable-qr	cold fission webrender	1,392.43 -> 637.28	Before/After
33%	espn ContentfulSpeedIndex	linux1804-64-shippable-qr	cold fission webrender	1,074.81 -> 720.11	Before/After
27%	espn ContentfulSpeedIndex	windows10-64-shippable-qr	cold fission webrender	858.44 -> 630.07	Before/After
17%	espn largestContentfulPaint	windows10-64-shippable-qr	cold fission webrender	619.00 -> 516.83	Before/After
14%	espn SpeedIndex	linux1804-64-shippable-qr	cold fission webrender	1,106.67 -> 946.28	Before/After
...	...	...	...	...	...
2%	google-search-restaurants LastVisualChange	android-hw-a51-11-0-aarch64-shippable-qr	warm webrender	687.69 -> 671.15	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 42365

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1888748

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Given the improvements are in metrics we actually care about, and the regressions are many less and in LastVisualChange only, I don't think this is worth digging into too much, but... Do you happen to have the side-by-side of the regression?

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Set severity S4 based on comment 2.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1888748

Comment 5

[Alex Finder| PTO returning Dec. 8th]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Given the improvements are in metrics we actually care about, and the regressions are many less and in LastVisualChange only, I don't think this is worth digging into too much, but... Do you happen to have the side-by-side of the regression?

Since revision d06a0d7b3 is in the bustage range, I was not able to generate the side-by-side job for that revision yet. There is a side-by-side job available for the next working revision. I'll try to see if I can get the results after a backout of the busted commit.

Comment 6

[Pascal Chevrel:pascalc]

Alex, any news on this bug?

Comment 7

[Alex Finder| PTO returning Dec. 8th]

(In reply to Pascal Chevrel:pascalc from comment #6)

Alex, any news on this bug?

Still working on the results, will have them ready on Wednesday.

Comment 8

[Alex Finder| PTO returning Dec. 8th]

(In reply to Alex Finder from comment #7)

(In reply to Pascal Chevrel:pascalc from comment #6)

Alex, any news on this bug?

Still working on the results, will have them ready on Wednesday.

Had to take a leave of absence last week, I'm looking into this today.

Comment 9

[Alex Finder| PTO returning Dec. 8th]

Tried submitting some try pushes on Android, but it seems I'm getting some errors on try for Android at the moment. I'll be back with results when the builds are working on try for Android.

Comment 10

[Alex Finder| PTO returning Dec. 8th]

Android jobs are no longer failing, so I'll retry submitting the try push for google-maps with a backout of d06a0d7b341361ec7d0e996636f94a7ebd68b92e. Just as an observation, looking at the overall graph for google-maps LastVisualChange on Android, it seems like it reverted to the previous value, before the regression occurred.