1894384 - [wpt-sync] Sync PR 45998 - Set minimum target size of 24px for appearance:base-select

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45998 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45998
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Set minimum target size of 24px for appearance:base-select

According to accessibility guidelines, we must ensure that all of the
pointer targets in appearance:base-select must be at least 24x24 CSS
pixels. https://github.com/openui/open-ui/issues/1026

Bug: 1511354
Change-Id: Iba814399e4061f7ce36c24296aef37a540444612

Reviewed-on: https://chromium-review.googlesource.com/5503502
WPT-Export-Revision: 1ad9b6f8a2b0e900eef42170315af81255f0dc2a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 45998 applied with additional changes from upstream: bc5292b8507cb38199367aa04fdca7b1028819d5, 82518a7571ce09bc958376b7648ec328568f5c30

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9dcec0730d63c2f6ba7ea932d9ddc30d7621bb87

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
FAIL: 6

Chrome

OK : 1
FAIL: 6

Safari

OK : 1
FAIL: 6

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/stylable-select/select-accessibility-minimum-target-size.tentative.html [wpt.fyi]
  • horizontal-tb "": Select with appearance:base-select should have targets for pointer inputs be at least 24x24 CSS pixels.: FAIL (Chrome: FAIL, Safari: FAIL)
  • vertical-lr "": Select with appearance:base-select should have targets for pointer inputs be at least 24x24 CSS pixels.: FAIL (Chrome: FAIL, Safari: FAIL)
  • vertical-rl "": Select with appearance:base-select should have targets for pointer inputs be at least 24x24 CSS pixels.: FAIL (Chrome: FAIL, Safari: FAIL)
  • horizontal-tb "i": Select with appearance:base-select should have targets for pointer inputs be at least 24x24 CSS pixels.: FAIL (Chrome: FAIL, Safari: FAIL)
  • vertical-lr "i": Select with appearance:base-select should have targets for pointer inputs be at least 24x24 CSS pixels.: FAIL (Chrome: FAIL, Safari: FAIL)
  • vertical-rl "i": Select with appearance:base-select should have targets for pointer inputs be at least 24x24 CSS pixels.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e78f0e4d4325
[wpt PR 45998] - Set minimum target size of 24px for appearance:base-select, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7f86f2d4413d
[wpt PR 45998] - Update wpt metadata, a=testonly

Comment 5

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/e78f0e4d4325
https://hg.mozilla.org/mozilla-central/rev/7f86f2d4413d