1894414 - Remove broken css rule

Status: RESOLVED FIXED

(Firefox :: Menus, task)

Description

[Gregory Pappas [:gregp]]

Bug 1859349's refactoring of panelUI-shared.css turned this rule:

panelmultiview[transitioning] > .panel-viewcontainer > .panel-viewstack > panelview > .panel-subview-body {
  overflow-y: hidden;
}

Into:

panelview {
  &[transitioning] > .panel-viewcontainer > .panel-viewstack > panelview > .panel-subview-body {
    overflow-y: hidden;
  }
}

Which is subtly incorrect. The transitioning attribute is only added to panelmultiview, not panelview, so the selector never matches anything.

To reduce confusion, this broken rule should be removed.

Comment 1

[Gregory Pappas [:gregp]]

• browser/themes/shared/customizableui/panelUI-shared.css#176-183

Comment 2

[luciamendozazumaran]

Hi,

I'm new to contributing in open source.
Can you assign me this?

Comment 3

[Gregory Pappas [:gregp]]

Hi,

you do not need to be manually assigned. The friendly robots will automatically assign you to the bug when you submit your patch.

Comment 4

[luciamendozazumaran]

I guess this is the link to the task? browser/themes/shared/customizableui/panelUI-shared.css#176-183

Comment 5

[Gregory Pappas [:gregp]]

Yes, it is.

Comment 6

[luciamendozazumaran]

So I did the changes and created a pull request, I got this: https://github.com/mozilla/gecko-dev/pull/563
Not sure if it is wrong or not

Comment 7

[Gregory Pappas [:gregp]]

GitHub pull requests are not supported. Please submit your changes to Phabricator,
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch

Comment 8

[Anand Roy [:aroy]]

Attachment: Bug 1894414 - Remove broken css rule r=gregp

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a321c0493631
Remove broken css rule r=desktop-theme-reviewers,emilio

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a321c0493631