1894423 - [clang-trunk] Perma js/src/threading/ExclusiveData.h:113:29: error: reference to non-static member function must be called

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Mike Hommey [:glandium]]

[task 2024-05-01T04:29:00.195Z] 04:29:00    ERROR -  /builds/worker/checkouts/gecko/js/src/threading/ExclusiveData.h:113:29: error: reference to non-static member function must be called
[task 2024-05-01T04:29:00.195Z] 04:29:00     INFO -    113 |       : lock_(std::move(rhs.lock)), value_(std::move(rhs.value_)) {
[task 2024-05-01T04:29:00.195Z] 04:29:00     INFO -        |                         ~~~~^~~~
[task 2024-05-01T04:29:00.195Z] 04:29:00     INFO -  1 error generated.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1894423 - Remove unused ExclusiveData move constructor.

Because the constructor is actually not used, the compiler used to not
complain about it being broken. Recent changes on clang trunk made it
catch this problem without the constructor being used.

As Mutex doesn't have a move constructor, it's also not only a matter of
adding the missing underscore to lock.

As the constructor is never used, just remove it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/223087fdc29f
Remove unused ExclusiveData move constructor. r=spidermonkey-reviewers,jonco

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/223087fdc29f