Open Bug 1894565 Opened 2 months ago Updated 26 days ago

Intermittent selection/non-themed-widget.html == selection/non-themed-widget-ref.html | single tracking bug

Categories

(Core :: Layout: Form Controls, defect, P5)

Product:
Core
Component:
Layout: Form Controls
Type:
defect

Tracking

()

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, intermittent-testcase)

I suspect this is the same underlying issue as bug 1894564. (It was reported at a similar time, and the log in comment 0 has the test failure from that bug as well.)

See Also: → 1894564

Though hmm, this test at least is annotated as needs-focus so presumably it did have focus when it ran, contrary to my theory about the other test in bug 1894564 comment 3.

Also: looking at the reftest analyzer screenshot from comment 0, it looks like the text is just a subtly-different shade of orange, for some reason -- and it's not an antialiasing thing, because the text doesn't seem to be antialiased at all. In the testcase, screenshot, every pixel of the text is #f07746, whereas in the reference case screenshot, every pixel of the text is #f28559 which is very-slightly-lighter.

Interestingly, those two colors are also used as the border and background for the textarea, in the screenshots for the reference and testcase. Both screenshots show the darker #f07746 as the border and the lighter #f28559 as the background.

(In reply to Daniel Holbert [:dholbert] from comment #2)

In the testcase, screenshot, every pixel of the text is #f07746, whereas in the reference case screenshot, every pixel of the text is #f28559 which is very-slightly-lighter.

Interestingly, those two colors are also used as the border and background for the textarea, in the screenshots for the reference and testcase. Both screenshots show the darker #f07746 as the border and the lighter #f28559 as the background.

Ah, the identical text color & background-color makes sense in the reference case; it's explicitly asking for the Highlight system color for both of those:
https://searchfox.org/mozilla-central/rev/38377227b8f96fda8f418db614e6a8aa67d01c31/layout/reftests/selection/non-themed-widget-ref.html#4-5,7,9

input {
  background-color: Highlight;
...
input::-moz-selection {
...
  color: Highlight;

Whereas in the testcase, we only set the background-color, and use default colors for everything else:
https://searchfox.org/mozilla-central/rev/38377227b8f96fda8f418db614e6a8aa67d01c31/layout/reftests/selection/non-themed-widget.html#4-6

input {
  background-color: Highlight;
}

So it looks like essentially this test is expecting that selected text should have its foreground color match the surrounding background-color (in a textarea); and when the test fails, we're not quite matching that expectation. I'm not sure whether that's an expectation that we fully expect to guarantee, though perhaps it's worked out until now?

CC emilio since he's been in the weeds of our form-field theming/coloring code over past years and might have some intuition about whether this test is valid vs. making unjustified assumptions...

Component: DOM: Selection → Layout: Form Controls

I think this is likely to be fallout from a recent infra change, tracked in bug 1895092 (and given that this is coloring-related, there's a good chance that jmaher's gtk-theme-forcing patch over there will help with this failure).

Depends on: 1895092
You need to log in before you can comment on or make changes to this bug.