1894638 - Stop using [array] in storage/

Status: NEW

(Core :: SQLite and Embedded Database Bindings, task, P3)

Description

[Marco Bonardo [:mak]]

See the blocked bug

Comment 1

[Marco Bonardo [:mak]]

There was a wip patch in https://bug1620702.bmoattachments.org/attachment.cgi?id=9131618

Comment 3

[Andrew McCreight [:mccr8]]

I looked at this a little, but it is a bit tricky. I think this is why Boris gave up. Anyways, Row is a wrapper around an nsIVariant, so doing this cleanly will likely require adding a new nsIVariant method that returns an nsTArray, then going through and implementing that in every layer of our variant implementations until you hit the point where it clones out the raw data from the underlying nsDiscriminated union.

Bug 1971994 demonstrates why this conversion is a good idea. Some new uses of the raw array GetBlob methods were added that failed to deal with freeing the buffer around error handling control flow, resulting in a slow but steady main process leak.