1894662 - Fix browser_download_idn_blocklist.js test with HTTPS first

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P2)

Comment 1

[Simon Friedberger (:simonf)]

Attachment: Bug 1894662 - Fix HTTPS first downgrades for proxies r=maltejur,ckerschb

r=maltejur,freddyb,ckerschb

For HTTPS first we want to treat NS_ERROR_UNKNOWN_HOST as an HTTPS
related error because it might be a 404 returned by a proxy (see
HttpProxyResponseToErrorCode). For the HTTPS-only case we don't want
that because it almost always is an unrelated error and the users would
have to confirm the interstitial every time to find out.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c07ec5ce9aa1
Fix HTTPS first downgrades for proxies r=maltejur,valentin

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing xpcshell failures in test_ext_dnr_private_browsing.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-TIMEOUT | xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_dnr_private_browsing.js | Test timed out

Comment 4

[Simon Friedberger (:simonf)]

This test failure seems unrelated to my change and the test completes fine in about 7 seconds on my machine. Should I just re-land?

Comment 5

[Serban Stanca [:SerbanS]]

Hi! As I pointed in Comment 3 there were several xpcshell failures that seemed to be started once your changeset landed on Autoland. Here you can see once again that there are several failures that started from your changeset and seemed to be resolved by the backout. Note that the failures seem to happen frequent (not perma) and only on Windows and Linux. If you are sure that this will not replicate once again, you can re-land but will be backout again otherwise.

Comment 6

[Frederik Braun [:freddy]]

FWIW, I think this might be an unrealted timeout. I just retriggered the test job within the push at https://treeherder.mozilla.org/jobs?repo=autoland&selectedJob=457500123&revision=c07ec5ce9aa1d890134ffb93e07d7d0335f27378. Let's see if it keeps failing.

Comment 7

[Simon Friedberger (:simonf)]

Disabling HTTPS-First for now since we can neither reliably fall back nor use an HTTPS server.

Comment 8

[Simon Friedberger (:simonf)]

Attachment: Bug 1894662 - Disable HTTPS-First for browser_download_idn_blocklist.js r=freddyb

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/182d2b0d21e2
Disable HTTPS-First for browser_download_idn_blocklist.js r=freddyb,mak

Comment 10

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/182d2b0d21e2