Support setting log modules from just one pref
Categories
(Core :: XPCOM, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox128 | --- | fixed |
People
(Reporter: julienw, Assigned: julienw)
References
Details
(Whiteboard: [fxp])
Attachments
(4 files)
When working on Fenix, setting log modules is currently cumbersome. It's possible to make it easier by setting all log modules in one go in a pref, parsing it in the preference watcher.
Assignee | ||
Comment 1•5 months ago
|
||
Assignee | ||
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Assignee | ||
Comment 2•5 months ago
|
||
This makes the new preference searchable in about:config, which is
very useful on Android.
This also moves the existing preference logging.config.clear_on_startup
to StaticPrefList.yaml.
Assignee | ||
Comment 3•5 months ago
|
||
Assignee | ||
Comment 4•5 months ago
|
||
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Comment 6•5 months ago
|
||
Backed out for causing failures related to DOCSHELL logging.
- Backout link
- Push with failures
- Failure Log
- Failure log:
[task 2024-05-16T17:56:40.493Z] 17:56:40 INFO - TEST-START | Shutdown
[task 2024-05-16T17:56:40.495Z] 17:56:40 INFO - Browser Chrome Test Summary
[task 2024-05-16T17:56:40.498Z] 17:56:40 INFO - Passed: 44
[task 2024-05-16T17:56:40.499Z] 17:56:40 INFO - Failed: 0
[task 2024-05-16T17:56:40.500Z] 17:56:40 INFO - Todo: 0
[task 2024-05-16T17:56:40.501Z] 17:56:40 INFO - Mode: e10s
[task 2024-05-16T17:56:40.502Z] 17:56:40 INFO - *** End BrowserChrome Test Results ***
[task 2024-05-16T17:56:40.593Z] 17:56:40 INFO - GECKO(1061) | [WARN webrender::device::gl] Missing optimized shader source for gpu_cache_update
[task 2024-05-16T17:56:40.645Z] 17:56:40 INFO - GECKO(1061) | [Child 1171, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (Conduits, ConduitClosed) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:61
[task 2024-05-16T17:56:40.649Z] 17:56:40 INFO - GECKO(1061) | [Child 1171, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (Conduits, ConduitClosed) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:61
[task 2024-05-16T17:56:40.725Z] 17:56:40 INFO - GECKO(1061) | [Child 1171, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (Conduits, ConduitClosed) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:61
[task 2024-05-16T17:56:40.730Z] 17:56:40 INFO - GECKO(1061) | [Child 1171, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (Conduits, ConduitClosed) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:61
[task 2024-05-16T17:56:40.746Z] 17:56:40 INFO - GECKO(1061) | [Child 1171, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (Conduits, ConduitClosed) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:61
[task 2024-05-16T17:56:40.790Z] 17:56:40 INFO - GECKO(1061) | [Child 1171, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (Conduits, ConduitClosed) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:61
[task 2024-05-16T17:56:40.795Z] 17:56:40 INFO - GECKO(1061) | [Child 1171, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (Conduits, ConduitClosed) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:61
[task 2024-05-16T17:56:40.825Z] 17:56:40 INFO - GECKO(1061) | [Child 1171, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (Conduits, ConduitClosed) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:61
[task 2024-05-16T17:56:40.913Z] 17:56:40 INFO - GECKO(1061) | [WARN webrender::device::gl] Missing optimized shader source for gpu_cache_update
[task 2024-05-16T17:56:41.292Z] 17:56:41 INFO - GECKO(1061) | 1715882201291 Marionette TRACE Received observer notification quit-application
[task 2024-05-16T17:56:41.293Z] 17:56:41 INFO - GECKO(1061) | 1715882201292 Marionette INFO Stopped listening on port 2828
[task 2024-05-16T17:56:41.298Z] 17:56:41 INFO - GECKO(1061) | 1715882201297 Marionette DEBUG Marionette stopped listening
[task 2024-05-16T17:56:41.330Z] 17:56:41 INFO - GECKO(1061) | [Parent 1061, Compositor] WARNING: Possibly dropping task posted to updater thread: file /builds/worker/checkouts/gecko/gfx/layers/apz/src/APZUpdater.cpp:395
[task 2024-05-16T17:56:41.342Z] 17:56:41 INFO - GECKO(1061) | [Child 1171, Main Thread] WARNING: IPC message 'PNecko::Msg_RemoveRequestContext' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:551
[task 2024-05-16T17:56:41.421Z] 17:56:41 INFO - GECKO(1061) | [Parent 1061, Compositor] WARNING: Possibly dropping task posted to updater thread: file /builds/worker/checkouts/gecko/gfx/layers/apz/src/APZUpdater.cpp:395
[task 2024-05-16T17:56:41.441Z] 17:56:41 INFO - GECKO(1061) | [Child 1213, Main Thread] WARNING: 'AppShutdown::IsInOrBeyond(ShutdownPhase::AppShutdownConfirmed)', file /builds/worker/checkouts/gecko/gfx/ipc/CanvasShutdownManager.cpp:97
[task 2024-05-16T17:56:41.442Z] 17:56:41 INFO - GECKO(1061) | [Child 1213, Main Thread] WARNING: 'AppShutdown::IsInOrBeyond(ShutdownPhase::AppShutdownConfirmed)', file /builds/worker/checkouts/gecko/gfx/ipc/CanvasShutdownManager.cpp:97
[task 2024-05-16T17:56:41.480Z] 17:56:41 INFO - GECKO(1061) | [Socket 1131, Socket Thread] WARNING: cannot post event if not initialized: file /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpConnectionMgr.cpp:240
[task 2024-05-16T17:56:41.482Z] 17:56:41 INFO - GECKO(1061) | [Socket 1131, Socket Thread] WARNING: cannot post event if not initialized: file /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpConnectionMgr.cpp:240
[task 2024-05-16T17:56:41.482Z] 17:56:41 INFO - GECKO(1061) | [Socket 1131, Socket Thread] WARNING: cannot post event if not initialized: file /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpConnectionMgr.cpp:240
[task 2024-05-16T17:56:42.073Z] 17:56:42 INFO - GECKO(1061) | [Child 1263, Main Thread] WARNING: 'AppShutdown::IsInOrBeyond(ShutdownPhase::AppShutdownConfirmed)', file /builds/worker/checkouts/gecko/gfx/ipc/CanvasShutdownManager.cpp:97
[task 2024-05-16T17:56:42.074Z] 17:56:42 INFO - GECKO(1061) | [Child 1263, Main Thread] WARNING: 'AppShutdown::IsInOrBeyond(ShutdownPhase::AppShutdownConfirmed)', file /builds/worker/checkouts/gecko/gfx/ipc/CanvasShutdownManager.cpp:97
[task 2024-05-16T17:56:42.076Z] 17:56:42 INFO - GECKO(1061) | [Child 1263, IPC I/O Child] WARNING: [A337A094FC1F09AB.29763E2738384764]: GetUserData call for port 'E092AD4C8E85EF60.5B907F82CE6C05EF' failed: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:425
[task 2024-05-16T17:56:42.081Z] 17:56:42 INFO - GECKO(1061) | [Child 1342, IPC I/O Child] WARNING: [D35D37526F98F66C.B1E99C2625A35589]: GetUserData call for port '28214F453779F727.F820E86A0FC22AC' failed: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:425
[task 2024-05-16T17:56:42.082Z] 17:56:42 INFO - GECKO(1061) | [Child 1342, Main Thread] WARNING: 'AppShutdown::IsInOrBeyond(ShutdownPhase::AppShutdownConfirmed)', file /builds/worker/checkouts/gecko/gfx/ipc/CanvasShutdownManager.cpp:97
[task 2024-05-16T17:56:42.082Z] 17:56:42 INFO - GECKO(1061) | [Child 1342, Main Thread] WARNING: 'AppShutdown::IsInOrBeyond(ShutdownPhase::AppShutdownConfirmed)', file /builds/worker/checkouts/gecko/gfx/ipc/CanvasShutdownManager.cpp:97
[task 2024-05-16T17:56:42.085Z] 17:56:42 INFO - GECKO(1061) | [Child 1342, IPC I/O Child] WARNING: [D35D37526F98F66C.B1E99C2625A35589]: GetUserData call for port 'A6844B4462173163.8F762D5E97739EE2' failed: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:425
<...>
[task 2024-05-16T17:56:42.687Z] 17:56:42 INFO - GECKO(1061) | Destroying context 7fe06da349e0 surface 0 on display 7fe093363400
[task 2024-05-16T17:56:43.334Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: '!top', file /builds/worker/checkouts/gecko/dom/xul/MenuBarListener.cpp:99
[task 2024-05-16T17:56:43.516Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:407
[task 2024-05-16T17:56:43.518Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:507
[task 2024-05-16T17:56:43.520Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:407
[task 2024-05-16T17:56:43.523Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:507
[task 2024-05-16T17:56:43.524Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:407
[task 2024-05-16T17:56:43.528Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:507
[task 2024-05-16T17:56:43.529Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:407
[task 2024-05-16T17:56:43.530Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:507
[task 2024-05-16T17:56:43.531Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:407
[task 2024-05-16T17:56:43.532Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:507
[task 2024-05-16T17:56:43.533Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:407
[task 2024-05-16T17:56:43.535Z] 17:56:43 INFO - GECKO(1061) | [Parent 1061, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:507
[task 2024-05-16T17:56:43.607Z] 17:56:43 INFO - TEST-INFO | Main app process: exit 0
[task 2024-05-16T17:56:43.610Z] 17:56:43 ERROR - TEST-UNEXPECTED-FAIL | did not see DOCSHELL log strings. this occurs if the DOCSHELL logging gets disabled by something. 0 created seen 0 destroyed seen
[task 2024-05-16T17:56:43.612Z] 17:56:43 ERROR - TEST-UNEXPECTED-FAIL | did not see DOMWINDOW log strings. this occurs if the DOMWINDOW logging gets disabled by something0 created seen 0 destroyed seen
[task 2024-05-16T17:56:43.613Z] 17:56:43 INFO - runtests.py | Application ran for: 0:00:45.146020
[task 2024-05-16T17:56:43.615Z] 17:56:43 INFO - zombiecheck | Reading PID log: /tmp/tmpnbwfzarapidlog
[task 2024-05-16T17:56:43.618Z] 17:56:43 INFO - ==> process 1061 launched child process 1131
[task 2024-05-16T17:56:43.620Z] 17:56:43 INFO - ==> process 1061 launched child process 1171
[task 2024-05-16T17:56:43.621Z] 17:56:43 INFO - ==> process 1061 launched child process 1213
[task 2024-05-16T17:56:43.622Z] 17:56:43 INFO - ==> process 1061 launched child process 1263
[task 2024-05-16T17:56:43.623Z] 17:56:43 INFO - ==> process 1061 launched child process 1269
[task 2024-05-16T17:56:43.624Z] 17:56:43 INFO - ==> process 1061 launched child process 1315
[task 2024-05-16T17:56:43.625Z] 17:56:43 INFO - ==> process 1061 launched child process 1322
[task 2024-05-16T17:56:43.628Z] 17:56:43 INFO - ==> process 1061 launched child process 1342
[task 2024-05-16T17:56:43.629Z] 17:56:43 INFO - ==> process 1061 launched child process 1389
[task 2024-05-16T17:56:43.630Z] 17:56:43 INFO - ==> process 1061 launched child process 1435
[task 2024-05-16T17:56:43.631Z] 17:56:43 INFO - ==> process 1061 launched child process 1464
[task 2024-05-16T17:56:43.632Z] 17:56:43 INFO - zombiecheck | Checking for orphan process with PID: 1315
[task 2024-05-16T17:56:43.633Z] 17:56:43 INFO - zombiecheck | Checking for orphan process with PID: 1322
[task 2024-05-16T17:56:43.634Z] 17:56:43 INFO - zombiecheck | Checking for orphan process with PID: 1131
[task 2024-05-16T17:56:43.635Z] 17:56:43 INFO - zombiecheck | Checking for orphan process with PID: 1389
[task 2024-05-16T17:56:43.636Z] 17:56:43 INFO - zombiecheck | Checking for orphan process with PID: 1263
[task 2024-05-16T17:56:43.637Z] 17:56:43 INFO - zombiecheck | Checking for orphan process with PID: 1171
[task 2024-05-16T17:56:43.638Z] 17:56:43 INFO - zombiecheck | Checking for orphan process with PID: 1269
[task 2024-05-16T17:56:43.639Z] 17:56:43 INFO - zombiecheck | Checking for orphan process with PID: 1464
[task 2024-05-16T17:56:43.640Z] 17:56:43 INFO - zombiecheck | Checking for orphan process with PID: 1435
[task 2024-05-16T17:56:43.641Z] 17:56:43 INFO - zombiecheck | Checking for orphan process with PID: 1213
[task 2024-05-16T17:56:43.643Z] 17:56:43 INFO - zombiecheck | Checking for orphan process with PID: 1342
[task 2024-05-16T17:56:43.644Z] 17:56:43 INFO - Stopping web server
[task 2024-05-16T17:56:43.645Z] 17:56:43 INFO - Server shut down.
[task 2024-05-16T17:56:43.646Z] 17:56:43 INFO - Web server killed.
[task 2024-05-16T17:56:43.647Z] 17:56:43 INFO - Stopping web socket server
[task 2024-05-16T17:56:43.648Z] 17:56:43 INFO - Stopping ssltunnel
[task 2024-05-16T17:56:43.649Z] 17:56:43 INFO - Stopping gst for v4l2loopback
[task 2024-05-16T17:56:43.650Z] 17:56:43 INFO - leakcheck | Processing log file /tmp/tmpu22jnqst.mozrunner/runtests_leaks.log for scope browser/base/content/test/popupNotifications/browser.toml
[task 2024-05-16T17:56:43.651Z] 17:56:43 INFO - TEST-INFO | leakcheck | default process: leak threshold set at 0 bytes
[task 2024-05-16T17:56:43.652Z] 17:56:43 INFO - TEST-INFO | leakcheck | tab process: leak threshold set at 0 bytes
[task 2024-05-16T17:56:43.653Z] 17:56:43 INFO - TEST-INFO | leakcheck | gmplugin process: leak threshold set at 20000 bytes
[task 2024-05-16T17:56:43.654Z] 17:56:43 INFO - TEST-INFO | leakcheck | gpu process: leak threshold set at 0 bytes
[task 2024-05-16T17:56:43.655Z] 17:56:43 INFO - TEST-INFO | leakcheck | vr process: leak threshold set at 0 bytes
[task 2024-05-16T17:56:43.656Z] 17:56:43 INFO - TEST-INFO | leakcheck | rdd process: leak threshold set at 0 bytes
[task 2024-05-16T17:56:43.657Z] 17:56:43 INFO - TEST-INFO | leakcheck | socket process: leak threshold set at 0 bytes
[task 2024-05-16T17:56:43.658Z] 17:56:43 INFO - TEST-INFO | leakcheck | sandboxbroker process: leak threshold set at 0 bytes
[task 2024-05-16T17:56:43.659Z] 17:56:43 INFO - TEST-INFO | leakcheck | forkserver process: leak threshold set at 0 bytes
[task 2024-05-16T17:56:43.660Z] 17:56:43 INFO - TEST-INFO | leakcheck | utility process: leak threshold set at 0 bytes
[task 2024-05-16T17:56:43.661Z] 17:56:43 INFO - leakcheck | Processing leak log file /tmp/tmpu22jnqst.mozrunner/runtests_leaks_tab_pid1342.log
[task 2024-05-16T17:56:43.662Z] 17:56:43 INFO - TEST-PASS | leakcheck | tab no leaks detected!
Assignee | ||
Comment 7•5 months ago
|
||
The previous patchset got backed out. Indeed it broke MOZ_LOG using the
environment variable. The reason is that the preference watcher was
called with an empty value after the log modules were set by the
enviroment variable handler at init time.
To fix this, this patch introduces a boolean property so that
DisableModules knows if the modules were previously set using the
preference logging.config.modules. As a result some functions are
renamed because of their changed behavior
Updated•5 months ago
|
Assignee | ||
Comment 8•5 months ago
|
||
new try: https://treeherder.mozilla.org/jobs?repo=try&revision=d9714996a2a52c2043aee9d82477d9183735af8d
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Comment 10•4 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b5e148d06cbf
https://hg.mozilla.org/mozilla-central/rev/863fe6a125ab
https://hg.mozilla.org/mozilla-central/rev/5fc574cdd42b
https://hg.mozilla.org/mozilla-central/rev/cbaee70fd3a0
Description
•