1894821 - Assertion failure: mIcon.payloads.Length() (The icon should have valid data), at /builds/worker/checkouts/gecko/toolkit/components/places/FaviconHelpers.cpp:977

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P3)

Description

[Tyson Smith [:tsmith]]

Found with m-c 20240502-dda5d5286866 (--enable-debug --enable-fuzzing)

This was found by visiting a live website with a debug build.

STR:

• Launch browser and visit site

This issue was triggered by visiting http://www.virginaustralia.com/.

Assertion failure: mIcon.payloads.Length() (The icon should have valid data), at /builds/worker/checkouts/gecko/toolkit/components/places/FaviconHelpers.cpp:977

68|0|xul.dll|mozilla::places::AsyncSetIconForPage::Run()|hg:hg.mozilla.org/mozilla-central:toolkit/components/places/FaviconHelpers.cpp:dda5d5286866494223d6cc52382d52032d961218|977|0x288
68|1|xul.dll|nsThread::ProcessNextEvent(bool, bool*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:dda5d5286866494223d6cc52382d52032d961218|1193|0xa68
68|2|xul.dll|NS_ProcessNextEvent(nsIThread*, bool)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:dda5d5286866494223d6cc52382d52032d961218|480|0x44
68|3|xul.dll|mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:dda5d5286866494223d6cc52382d52032d961218|330|0x124
68|4|xul.dll|MessageLoop::RunHandler()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:dda5d5286866494223d6cc52382d52032d961218|363|0x4f
68|5|xul.dll|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:dda5d5286866494223d6cc52382d52032d961218|345|0x6e
68|6|xul.dll|nsThread::ThreadFunc(void*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:dda5d5286866494223d6cc52382d52032d961218|370|0x15a
68|7|nss3.dll|_PR_NativeRunThread(void*)|hg:hg.mozilla.org/mozilla-central:nsprpub/pr/src/threads/combined/pruthr.c:dda5d5286866494223d6cc52382d52032d961218|399|0x120
68|8|nss3.dll|pr_root(void*)|hg:hg.mozilla.org/mozilla-central:nsprpub/pr/src/md/windows/w95thred.c:dda5d5286866494223d6cc52382d52032d961218|139|0x10
68|9|ucrtbase.dll||||
68|10|KERNELBASE.dll||||
68|11|mozglue.dll|patched_BaseThreadInitThunk(int, void*, void*)|hg:hg.mozilla.org/mozilla-central:toolkit/xre/dllservices/mozglue/WindowsDllBlocklist.cpp:dda5d5286866494223d6cc52382d52032d961218|558|0x74
68|12|ntdll.dll||||
68|13|KERNELBASE.dll||||

Comment 1

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/IMm7rPevzK19StSS23ix9g/index.html

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1552815

:daisuke, since you are the author of the regressor, bug 1552815, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Mark Banner (:standard8)]

Leaving NI for Daisuke to take a look at this to triage what the actual issue is. It would probably also be worth looking at the Pernosco session soon as we don't know if/when they expire.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Oh, I'm so sorry, I realized this ni now.
I will take a look at this tomorrow.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1894821: Throw NS_ERROR_FILE_TOO_BIG if the favicon data size is over than MAX_FAVICON_BUFFER_SIZE

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1552815

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24d6b6d5ed41
Throw NS_ERROR_FILE_TOO_BIG if the favicon data size is over than MAX_FAVICON_BUFFER_SIZE r=places-reviewers,mak,migration-reviewers,mconley

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/24d6b6d5ed41

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.