1894858 - Update android nightly application-services version bump to new version 5e198a9ab0001e91535e9dfc8908e56bdcfe1c6a from 2024-05-03 05:02:36

Status: RESOLVED FIXED

(Fenix :: General, enhancement)

Description

[Update Bot]

This update covers 3 commits. Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

5e198a9ab0001e91535e9dfc8908e56bdcfe1c6a by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/5e198a9ab0001e91535e9dfc8908e56bdcfe1c6a
Authored: 2024-05-01 17:29:19 -0700
Committed: 2024-05-02 18:33:26 +0000

nimbus-gradle-plugin: Use withStream to consume InputStreams.

This ensures that the streams are closed after they're consumed.

Files Modified:

• tools/nimbus-gradle-plugin/src/main/groovy/org/mozilla/appservices/tooling/nimbus/NimbusGradlePlugin.groovy

---

37c4ca7824d1ddfb755d14d1e6e6fcdb2c955848 by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/37c4ca7824d1ddfb755d14d1e6e6fcdb2c955848
Authored: 2024-05-02 10:52:52 -0700
Committed: 2024-05-02 18:33:26 +0000

nimbus-gradle-plugin: Clarify that cacheDir is always non-null.

Files Modified:

• tools/nimbus-gradle-plugin/src/main/groovy/org/mozilla/appservices/tooling/nimbus/NimbusGradlePlugin.groovy

---

ebded2fe14bd28cd4e9ade7eb05234ddba671c32 by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/ebded2fe14bd28cd4e9ade7eb05234ddba671c32
Authored: 2024-05-01 17:28:23 -0700
Committed: 2024-05-02 18:33:26 +0000

nimbus-gradle-plugin: Support absolute and relative file paths.

This commit refactors how the Nimbus Gradle Plugin handles
project-relative directories, so that developers can specify
relative and absolute paths to Application Services in the
autoPublish.application-services.dir property when using the Fenix
auto-publishing workflow.

The changes are:

• Use project.file(...) to resolve paths relative to the
  project directory, instead of the File constructor. The
  .file() method understands absolute paths.
• Use project.layout.buildDirectory.dir(...) to resolve
  paths relative to the build directory, instead of manually
  building the path from the deprecated project.buildDir
  property.
• Use / instead of File.separator for paths. This is the style
  that Gradle recommends, and it simplifies how we build path strings.
  The Java File APIs canonicalize / to \ on Windows, so it's
  not necessary to use File.separator explicitly.

Files Modified:

• tools/nimbus-gradle-plugin/src/main/groovy/org/mozilla/appservices/tooling/nimbus/NimbusGradlePlugin.groovy

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=920f3886734db8931f638e22dd9ec9d55e1d29c3

Comment 2

[Update Bot]

Attachment: Bug 1894858 - Update android nightly application-services version bump to 5e198a9ab0001e91535e9dfc8908e56bdcfe1c6a

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51cbae66d05e
Update android nightly application-services version bump to 5e198a9ab0001e91535e9dfc8908e56bdcfe1c6a r=dmeehan

Comment 4

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/51cbae66d05e