Closed
Bug 1894949
Opened 5 months ago
Closed 2 months ago
Do not reset profile to "responsive" on viewport size changes in RDM
Categories
(DevTools :: Responsive Design Mode, defect, P2)
DevTools
Responsive Design Mode
Tracking
(firefox130 fixed)
RESOLVED
FIXED
130 Branch
| Tracking | Status | |
|---|---|---|
| firefox130 | --- | fixed |
People
(Reporter: twisniewski, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Attempts to resize the viewport in the RDM resets the custom user-agent string and touch-event toggle, which can make it more time-consuming to debug webcompat issues.
|
||
Updated•4 months ago
|
Severity: -- → S3
Priority: -- → P2
|
Assignee | |
Comment 1•2 months ago
|
||
When changing the UA input value, or clicking on the touch simulation button,
we set a specific flag in the RDM state to avoid updating UA/Touch Simulation
when selecting a device/resizing the viewport.
In such case, a "reset" button will be displayed so the user can apply the selected
device settings, or reset UA/touch simulation when no device is selected.
Once the reset button is clicked, it gets hidden, and we "re-sync" the UA input/
touch simulation on device change.
A test is added to cover these different cases.
|
||
Updated•2 months ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
|
|
||
Updated•2 months ago
|
Attachment #9412047 -
Attachment description: Bug 1894949 - [devtools] Persist changes made to UA/Touch Simulation when changing device. r=#devtools-reviewers. → Bug 1894949 - [devtools] Don't reset dpr/UA/Touch Simulation when resizing viewport. r=#devtools-reviewers.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f4e4b1ec932e [devtools] Don't reset dpr/UA/Touch Simulation when resizing viewport. r=devtools-reviewers,jdescottes.
|
||
Comment 3•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox130:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•