1894964 - [linkedin.com] Search is not working on Nightly

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[alex_mayorga]

Steps:

• Load and log-in into linkedin.com
• Use the search bar to get some results

Actual result:
LinkedIn gives an error message

Expected result:
Search results are shown

I captured a profile at
https://share.firefox.dev/3w8nrR2

Comment 1

[Pascal Chevrel:pascalc]

I can reproduce it with Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0 ID:20240501214803

I am not seeing this bug on the release channel (125)

Comment 2

[Pascal Chevrel:pascalc]

Just tried in 1360.b8 and it works. Example URL:
https://www.linkedin.com/search/results/all/?keywords=google%20recaptcha&origin=GLOBAL_SEARCH_HEADER&sid=fmG

Comment 3

[Pascal Chevrel:pascalc]

Attachment: ErrorConsole.txt

Comment 4

[Pascal Chevrel:pascalc]

On NIghtly, I have this error in the console:
Error while processing route: search.results.generic.index too much recursion Oe@https://static.licdn.com/aero-v1/sc/h/bpj7j23zixfggs7vvsaeync9j:1249:56

Comment 5

[Alice0775 White]

It can be reproduced by performing the search twice with a new profile.

Regression window:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0440fed29cf1ba7c3dfbc98d8754e68da2a4a3ab&tochange=fd5c3f94549dc738a16fd44ef06efbb6aa1d2300

Suspect: Bug 1878158

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

:alexical, since you are the author of the regressor, bug 1878158, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 7

[Outvi V]

Hi. I have a smaller (but probably not small enough) repro case about another regression on Bug 1878158, probably related: Vue SFC Playground.

In Chromium and FF Nightly 2024-04-28 it should give with 2 zeros, but in later FF Nightly it will throw an exception.

I had a dig in this case and noticed that before the exception this size getter, when called with Reflect.get(), gets the target (1st parameter) as this rather than receiver (3rd parameter) when get called.

function createInstrumentations() {
  const mutableInstrumentations2 = {
    get(key) {
      return get(this, key);
    },
    get size() {
      return size(this); // <--
    },
// ...

Comment 8

[Pascal Chevrel:pascalc]

Fixed by the backout of bug 1878158

Comment 9

[alex_mayorga]

¡Hola y'all!

Happy 🌮 Tuesday!

VERIFIED FIXED on Nightly built from

https://hg.mozilla.org/mozilla-central/rev/8d47b53b92aab287aee923b25739e74f89cc323f

FWIW.

¡Gracias! 🖖🏽

Comment 10

[Daniel Holbert [:dholbert]]

updating 127 status to 'verified (as fixed)' per comment 8 - comment 9. Thanks!

(And I think we can clear the ni for the regressor, given that this has been addressed via backout now.)