1894976 - Try repository task l10n(l1nt-conflicts) fails for every push for which it gets scheduled

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: Automation, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Example: https://treeherder.mozilla.org/jobs?repo=try&revision=76763ae17243c3742a79302d46109054d7fa75d7&selectedTaskRun=L6A2SVEJRQO62Y_9cZ2Rdw.0
Treeherder's 'Similar Jobs' tab at the bottom shows it fails always.

Log: https://treeherder.mozilla.org/logviewer?job_id=456868250&repo=try

[task 2024-05-03T16:26:47.861Z] Creating default state directory: /builds/worker/.mozbuild
[task 2024-05-03T16:26:47.861Z] Creating local state directory: /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69
[task 2024-05-03T16:26:55.813Z] TEST-UNEXPECTED-WARNING | /builds/worker/checkouts/gecko/tools/lint/l10n.yml:0 | file format not supported in compare-locales (l10n)
[task 2024-05-03T16:26:55.813Z] TEST-UNEXPECTED-WARNING | /builds/worker/checkouts/gecko/tools/lint/l10n.yml:0 | file format not supported in compare-locales (l10n)
[task 2024-05-03T16:26:55.813Z] TEST-UNEXPECTED-WARNING | /builds/worker/checkouts/gecko/tools/lint/l10n.yml:0 | file format not supported in compare-locales (l10n)
[task 2024-05-03T16:26:55.813Z] TEST-UNEXPECTED-WARNING | /builds/worker/checkouts/gecko/tools/lint/l10n.yml:0 | file format not supported in compare-locales (l10n)

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

All the pushes which ran the task are from reviewbot , and all in the last 4 months failed it. Is this an issue with the bot or the task setup?

Comment 2

[Francesco Lodolo [:flod]]

It looks like the problem is that the linter tries to parse l10n.yml itself. Not exactly sure what changed to cause this.

Comment 3

[Francesco Lodolo [:flod]]

Actually, the file is explicitly added, and the file hasn't been changed in 5 years
https://searchfox.org/mozilla-central/source/tools/lint/l10n.yml#19

Removing it from the list gets rid of the warnings. Still, not sure why it ever worked, if that's the case.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The task seems to run more frequently because of the changes in bug 1885361 which landed yesterday European morning on central.

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Bug 1894976 - Exclude l10n.yml when parsing localizable files in l10n linter, r=eemeli

Comment 6

[Eemeli Aro [:eemeli]]

Why not "just" remove tools/lint/l10n.yml from the include list? While it's always been there (since bug 1353680), I can't figure out why it's there. As it's marked as a support file, changes to it already trigger linting the entire tree.

I also can't see how the behaviour of this could've changed in the past few months.

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Eemeli Aro [:eemeli] from comment #6)

Why not "just" remove tools/lint/l10n.yml from the include list? While it's always been there (since bug 1353680), I can't figure out why it's there. As it's marked as a support file, changes to it already trigger linting the entire tree.

Because that's needed for validate_linter_includes() (check that all paths listed in TOML files are included in the linter configuration).

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3914f7addd7
Exclude l10n.yml when parsing localizable files in l10n linter, r=eemeli

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f3914f7addd7