1895052 - Update android nightly application-services version bump to new version f87a569e36804553dff78c58f9a12bb6079f6ec2 from 2024-05-04 05:02:47

Status: RESOLVED DUPLICATE of bug 1891157

(Fenix :: General, enhancement)

Description

[Update Bot]

This update covers 3 commits. Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

f87a569e36804553dff78c58f9a12bb6079f6ec2 by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/f87a569e36804553dff78c58f9a12bb6079f6ec2
Authored: 2024-04-29 14:39:27 -0700
Committed: 2024-05-03 07:03:49 +0000

fxa_client: Add telemetry plumbing for the "close tabs" command.

Files Modified:

• components/fxa-client/src/internal/close_tabs.rs
• components/fxa-client/src/internal/commands/close_tabs.rs
• components/fxa-client/src/internal/device.rs
• components/fxa-client/src/internal/telemetry.rs
• components/sync_manager/android/src/main/java/mozilla/appservices/syncmanager/SyncTelemetry.kt

---

c6fdae855cb2069b8326879bf18902c976a78159 by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/c6fdae855cb2069b8326879bf18902c976a78159
Authored: 2024-03-11 16:53:35 -0700
Committed: 2024-05-03 07:03:49 +0000

fxa_client: Specify a 48-hour TTL for the "close tabs" command.

Files Modified:

• components/fxa-client/src/internal/close_tabs.rs
• components/fxa-client/src/internal/commands/close_tabs.rs
• components/fxa-client/src/internal/device.rs
• components/fxa-client/src/internal/http_client.rs
• components/fxa-client/src/internal/send_tab.rs

---

f2b1d5a1322cb1caa78a6f657b0ce5902d98241a by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/f2b1d5a1322cb1caa78a6f657b0ce5902d98241a
Authored: 2024-03-08 15:57:00 -0800
Committed: 2024-05-03 07:03:49 +0000

fxa_client: Add support for the "close tabs" command.

Files Added:

• components/fxa-client/src/internal/close_tabs.rs
• components/fxa-client/src/internal/commands/close_tabs.rs

Files Modified:

• components/fxa-client/android/src/main/java/mozilla/appservices/fxaclient/FxaClient.kt
• components/fxa-client/ios/FxAClient/FxAccountDeviceConstellation.swift
• components/fxa-client/ios/FxAClient/PersistedFirefoxAccount.swift
• components/fxa-client/src/device.rs
• components/fxa-client/src/fxa_client.udl
• components/fxa-client/src/internal/commands/mod.rs
• components/fxa-client/src/internal/commands/send_tab.rs
• components/fxa-client/src/internal/device.rs
• components/fxa-client/src/internal/mod.rs
• components/fxa-client/src/internal/send_tab.rs
• components/fxa-client/src/lib.rs
• components/fxa-client/src/push.rs
• examples/fxa-client/src/send_tab.rs

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=7f2b2f2d6e8da566bba38540ab4b1cd772d6c653

Comment 2

[Update Bot]

Attachment: Bug 1895052 - Update android nightly application-services version bump to f87a569e36804553dff78c58f9a12bb6079f6ec2

Comment 3

[Donal Meehan [:dmeehan]]

:lina CI on try is failing due to https://github.com/mozilla/application-services/commit/f2b1d5a1322cb1caa78a6f657b0ce5902d98241a

Comment 4

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• toolchain-linux64-android-gradle-dependencies - 1 of 1 failed (failed: BM1OBmTJQ-CSO77gl4JIMw)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Lina Butler [:lina]]

Sorry about that! This is "expected", because we added a new device command to the FxA Client Rust component, and our Android Components match on those exhaustively.

I'll go ahead and fold this into bug 1891157, and land the first patch in that series today—it's already approved, and it's easier to land that change together with this version bump.

Comment 6

[Lina Butler [:lina]]

Landed as part of https://hg.mozilla.org/integration/autoland/rev/ea67e3b59c22cea8a2c797ce9a6608d3ddeaeca9. (I'll land the rest of the patch stack in bug 1891157 tomorrow; there are a few more pieces there I wanted to fix up there).

Thanks for following up, Donal—and sorry I didn't give you a heads-up in advance!