1895179 - Mark !important values for supported properties in @position-try as invalid

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

From https://drafts.csswg.org/css-anchor-position-1/#fallback-rule:

It is invalid to use !important on the properties in the <declaration-list>. Doing so causes the property it is used on to become invalid, but does not invalid the @property-try rule as a whole.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1895179 - Add rule SupportsOptions for InspectorUtils.supports to check support for a given rule type. r=#layout-reviewers.

In some cases, a declaration will be valid for a rule type, and not for another
rule type. At the moment, InspectorUtils.supports will only watch the validity
of the passed string for CssRuleType::Style.
This patch adds a rule option to SupportsOptions, from which we then
extract its type and pass it to Servo_CSSSupports so we can check the validity
of a string against a specific rule type.

Test cases are added in layout/inspector/tests/test_supports.html.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1895179 - [devtools] Mark declaration with !important values as invalid in @position-try rules. r=#devtools.

This will make it possible to check the validity of a declaration for a specific rule,
for example, we'll be able to detect !important invalid declaration value in @position-try rules.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1895179 - [devtools] Fix checking valid declaration in checkRuleViewContent. r=#devtools

The assertion was hard to parse and not working as expected.

Comment 4

[Phabricator Automation]

Comment on attachment 9531077 [details]
Bug 1895179 - Add rule SupportsOptions for InspectorUtils.supports to check support for a given rule type. r=#layout-reviewers.

Revision D275192 was moved to bug 2004379. Setting attachment 9531077 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5a7bbc46f6da
https://hg.mozilla.org/integration/autoland/rev/c2fb7edc024a
[devtools] Fix checking valid declaration in checkRuleViewContent. r=devtools-reviewers,bomsy
https://github.com/mozilla-firefox/firefox/commit/3e26fc1cb82c
https://hg.mozilla.org/integration/autoland/rev/85db22e38540
[devtools] Mark declaration with !important values as invalid in @position-try rules. r=devtools-reviewers,ochameau.

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c2fb7edc024a
https://hg.mozilla.org/mozilla-central/rev/85db22e38540

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1895179 - [devtools] Fix checking valid declaration in checkRuleViewContent.

The assertion was hard to parse and not working as expected.

Original Revision: https://phabricator.services.mozilla.com/D275228

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: This stack of patches adds minimal DevTools support for @position-try rules, which are part of Anchor positioning, which was enabled by default in 147.
  Without this, users might think that the implementation is incomplete and that @position-try is not supported.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: low
• Explanation of risk level: This is DevTools only, covered by tests.
  Even though this is not a small change, we're not doing anything extraordinarily new, mostly just adding on existing mechanism in DevTools
• String changes made/needed: inactive-css-at-position-try-not-supported was added
• Is Android affected?: yes

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1895179 - [devtools] Mark declaration with !important values as invalid in @position-try rules. .

Original Revision: https://phabricator.services.mozilla.com/D275193

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2c98b3f9a89d
https://hg.mozilla.org/releases/mozilla-beta/rev/785bf2502c0c
https://github.com/mozilla-firefox/firefox/commit/c426fd01e1ab
https://hg.mozilla.org/releases/mozilla-beta/rev/91b5fa337e3a