Closed
Bug 1895198
Opened 21 days ago
Closed 20 days ago
Move the assert !LoadWasOpened() in HttpBaseChannel::ExplicitSetUploadStreamLength to HttpChannelChild
Categories
(Core :: Networking, task, P2)
Core
Networking
Tracking
()
RESOLVED
FIXED
127 Branch
| Tracking | Status | |
|---|---|---|
| firefox127 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webdriver:m11][necko-triaged])
Attachments
(1 file)
For WebDriver BiDi, we need to modify the request body late (currently in http-on-before-connect), but this currently fails on the following assert:
https://searchfox.org/mozilla-central/rev/e69f323af80c357d287fb6314745e75c62eab92a/netwerk/protocol/http/HttpBaseChannel.cpp#1323
After discussing with :valentin, since BiDi only ever calls this from the parent process and this assert is only relevant for the content process, we should be able to split the implementation between HttpBaseChannel and HttpChannelChild, and only keep the assert in the Child version.
|
Assignee | |
Updated•21 days ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•21 days ago
|
Component: WebDriver BiDi → Networking
Product: Remote Protocol → Core
|
|
Assignee | |
Comment 1•21 days ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ead376db22e7 Add ExplicitSetUploadStreamLength to HttpChannelChild and move LoadWasOpened assert r=valentin,necko-reviewers
|
||
Updated•21 days ago
|
Severity: -- → N/A
Whiteboard: [webdriver:m11] → [webdriver:m11][necko-triaged]
|
|
Assignee | |
Updated•20 days ago
|
Points: --- → 2
|
||
Comment 3•20 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 20 days ago
status-firefox127:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•