1895232 - Convert do_GetService to using components::*::service in netwerk/

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Description

[Valentin Gosu [:valentin] (he/him)]

There are a lot of places where we still use do_GetService("string_contract_id") in netwerk/ - see link

It could be a minor performance boost if we switch to using mozilla::components::Name::Service() - like for IO, DNS, SocketTransport, CacheStorage, etc.

If we find some of the services don't have a name in the components.conf file, we should add one.

Comment 1

[Sean Kim]

Attachment: Bug 1895232 - Convert do_GetService to using components::*::service in netwerk/ r?valentin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a295c851c2e
Convert do_GetService to using components::*::service in netwerk/ r=valentin,cookie-reviewers,places-reviewers

Comment 3

[Iulian Moraru]

Backed out for causing multiple failures.

• Push with failures

• Failure log for build bustages

• Failure log for bc failures

• Failure log for xpcshell failures

• Backout link

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/383fd26bb6e2
Convert do_GetService to using components::*::service in netwerk/ r=valentin,cookie-reviewers,places-reviewers

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/383fd26bb6e2