1895244 - Crash reporter branded lookup needs to be adjusted - now falls back to "Firefox Crash Reporter" for Thunderbird

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Magnus Melin [:mkmelin]]

See bug 1893646. Filing this based on bug 1893646 comment 6.

Comment 1

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1895244 - Add Thunderbird files to omnijar localization logic r=gsvelto

I also realized the logging environment variables were incorrect and
fixed that.

Comment 2

[Alex Franchuk [:afranchuk]]

It turns out the path is just wrong and it should always be localization/{locale}/crashreporter/crashreporter.ftl (discovered after fixing bug 1895599). The branding does need to be adjusted, though.

Comment 3

[Martin Giger [:freaktechnik]]

Made a local build with this patch and the patch from bug 1895599 (resolving the "conflict" between them). It picks up our strings now, thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31f9ba5b621e
Add Thunderbird files to omnijar localization logic r=gsvelto

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/518b7df77ee0
Backed out changeset 31f9ba5b621e for causing conflict with changes that need to be uplifted to release (requested by dmeehan).

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gsvelto, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a91aa8581bbc
Add Thunderbird files to omnijar localization logic r=gsvelto

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a91aa8581bbc

Comment 9

[Wayne Mery (:wsmwk)]

Does this fix what I reported 16 years ago in bug 455937?

Comment 10

[Alex Franchuk [:afranchuk]]

(In reply to Wayne Mery (:wsmwk) from comment #9)

Does this fix what I reported 16 years ago in bug 455937?

Yes. And at the very least that bug can be closed because crashreporter-override.ini no longer exists!