1895434 - Performance tab in the toolbox doesn't stay hidden

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Ed]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:125.0) Gecko/20100101 Firefox/125.0

Steps to reproduce:

Pressed ctrl-alt-shift-i to open the Browser Toolbox

Pressed F1 to open Settings

Unchecked Performance

Closed and re-opened the toolbox

Actual results:

Performance was present and unchecked in the settings.

Expected results:

Performance should not have been present and should have remained unchecked in the settings.

Comment 1

[Ed]

Performance does stay hidden as expected on the Web Developer Tools (ctrl-shift-i) .

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Julian Descottes [:jdescottes]]

Thanks for the report, seems to only affect the Performance tab!

Comment 4

[Ed]

(In reply to Julian Descottes [:jdescottes] from comment #3)

Thanks for the report, seems to only affect the Performance tab!

Yeah, I didn't test all of the options but the ones I did test stayed hidden.

Comment 5

[Julian Descottes [:jdescottes]]

The panel preference is explicitly forced to true every time we open the Browser Toolbox over at

  // We force enabling the performance panel in the browser toolbox.
  Services.prefs.setBoolPref("devtools.performance.enabled", true);

https://searchfox.org/mozilla-central/rev/ee2ad260c25310a9fbf96031de05bbc0e94394cc/devtools/client/framework/browser-toolbox/window.js#141

From the review https://phabricator.services.mozilla.com/D143566 it seems that the idea is that we want to enable the Performance tool in the Browser Toolbox by default even if the user did not enable it in the regular DevTools. But I guess we should still follow the user preference if they decided to set an explicit value? Or if technically impossible, we should disable the checkbox in the Settings panel.

Comment 6

[Julian Descottes [:jdescottes]]

Given the way we setup the profile of the Browser Toolbox, there is no way to know if the value of devtools.performance.enabled is a user value or not.

However I think that the initial intent of forcing the pref to true was to force the "new" performance panel to be used when the "old" was still available. I don't think there is much value in forcing the panel to be displayed or not? devtools.performance.enabled is true by default, so only folks who explicitly disabled it in the regular toolbox would have to remove it.

I think we could just remove this.

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1895434 - [devtools] Stop forcing the Performance panel to be displayed in the Browser Toolbox

This logic was probably relevant when the old performance panel was still a thing

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91f506042b8a
[devtools] Stop forcing the Performance panel to be displayed in the Browser Toolbox r=devtools-reviewers,nchevobbe

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/91f506042b8a

Comment 10

[Ed]

Thanks for fixing it. FYI, https://new.reddit.com/r/firefox/comments/1cm3id2/is_there_a_way_to_either_disable_the_firefox/ is what prompted me to file this bug.