1895463 - There should be a clear separation between the multiple selections of text that are translated

Status: NEW

(Firefox :: Translations, enhancement)

Description

[Daniel Bodea [:danibodea]]

Note

• When a user selects multiple strings of text and triggers the Select Translations panel, there should be a clear separation between the translated parts in the panel.

Found in

• Nightly 127.0a1

Affected versions

• Nightly 127.0a1

Tested platforms

• Affected platforms: all
• Unaffected platforms: none

Steps to reproduce

1. Ensure Select Translations is enabled.
   browser.translations.select.enable = TRUE
2. Load a webpage that is displayed in a different language than the browser's (and supported).
   https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal
3. Select multiple bits of text (using the mouse, while holding down the CTRL button)
4. Open the context menu and select the "Translate Selection to <browser language>" option.

Expected result

• The panel should show a clear separation between the multiple translated bits of text.

Actual result

• The panel displays the multiple translated selections of text one after the other and even joins the 2 parts together

Regression range

• Not a regression.

Additional notes

Comment 1

[Daniel Bodea [:danibodea]]

Attachment: Multiple selections of text are being joined togeter in the Select Translations panel.webm

Demo of improper functionality.

Comment 2

[Greg Tatum [:gregtatum]]

Thanks for filing. This needs to be fixed in the multiple text selection code itself, and is an existing issue.

nsContextMenu.selectionInfo.fullText doesn't add spaces between different chunks of text.