1895573 - [toolbar redesign] navbar is visible for a short time when address toolbar is clicked

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P1)

Description

[Mike a [:mavduevskiy]]

Steps to reproduce

precondition: a lower end device or a debug mode to slow down animations

1. open a website
2. click the address bar

Expected behavior

The navbar gets replaced by the search bar

Actual behavior

For a short moment, they both are visible and only then the nav bar gets hidden

Device information

• Firefox version: 127
• Android device model: mid-range samsung
• Android OS version: android 14

Any additional information?

Comment 1

[Mike a [:mavduevskiy]]

Attachment: Screen_recording_20240507_115844.mp4

Comment 2

[Chris Peterson [:cpeterson]]

Setting toolbar redesign's Nightly blockers to priority P1.

Comment 3

[Mike a [:mavduevskiy]]

Attachment: Bug 1895573 - Fix showing display and edit mode at the same time

Comment 4

[Mike a [:mavduevskiy]]

Attachment: not_fixed.mp4

attaching a video showing the problem

Comment 5

[Mike a [:mavduevskiy]]

Attachment: fixed.mp4

attaching the fixed version from the patch

(attaching video on phabricator seems broken)

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Looked over and played a bit with the proposed change.
It does fix the scenario of having two toolbars shown at time by replacing it with having no toolbar at a time.
In my testing this is a bit cleaner and easier on the eye but it shows there's a bigger issue to address.

Because a picture is worth a thousand words and so a video would be worth more I tried recording a comparison I've made of related scenarios which I'd say show the need of a bigger followup / refactoring.
https://drive.google.com/file/d/1wqBKLmroXT0bg-MGkuxZCc7EDSXgCXCa/view?usp=sharing

Based on the above I'd propose to land the current patch as is but make it a priority to refactor the toolbar to better support changing modes.
Will ask in the squad for feedback.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47a7330fb6c9
Fix showing display and edit mode at the same time r=android-reviewers,petru

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/47a7330fb6c9