1895612 - Migrate old prefs to new prefs again to re rollout the new clear history dialog

Status: VERIFIED FIXED

(Toolkit :: Data Sanitization, task, P1)

Description

[Harshit Sohaney]

We have to conduct another migration for users to avoid major confusion for users who made any changes to their clearing settings before rolling out the new clear history dialog.

Comment 1

[Harshit Sohaney]

Attachment: Bug 1895612 - Add new prefs to run the clear history pref migration again for all users for the new clear history dialog. r?pbz

Depends on D208411

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/312e99c344d5
Add new prefs to run the clear history pref migration again for all users for the new clear history dialog. r=pbz

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/312e99c344d5

Comment 4

[Oana Botisan, Desktop QA]

Hello all,

Can you please provide us with a list of prefs that we should verify and what are the values that they should have in which senarios?
Because we verified that privacy.sanitize.useOldClearHistoryDialog is set to false by default in NIghtly 128.0a1 on all platforms. But I see in the patch that there are a lot more prefs that have been changed.

Thank you.

Comment 5

[Harshit Sohaney]

pref migrations:

privacy.clearOnShutdown.history --> privacy.clearOnShutdown_v2.historyFormDataAndDownloads (only the history value matters, downloads and formdata are ignored in this migration privacy.clearOnShutdown.downloads, privacy.clearOnShutdown.formdata )

privacy.clearOnShutdown.cookies --> privacy.clearOnShutdown_v2.cookiesAndStorage (only cookie value matters, active logins and offline website data are ignored in this migration)

privacy.clearOnShutdown.cache --> privacy.clearOnShutdown_v2.cache

privacy.clearOnShutdown.siteSettings --> privacy.clearOnShutdown_v2.siteSettings

let me know if this clears things up!

Comment 6

[Oana Botisan, Desktop QA]

We verified the prefs on Nightly 128.0a1 using macOS 12, Windows 11 and Ubuntu 22. These are the values that we got:

• privacy.clearOnShutdown_v2.historyFormDataAndDownloads - true
• privacy.clearOnShutdown_v2.cookiesAndStorage - true
• privacy.clearOnShutdown_v2.cache - true
• privacy.clearOnShutdown_v2.siteSettings - false

Is this the expected result?

Comment 7

[Harshit Sohaney]

This is the expected result given that the user had:
privacy.clearOnShutdown.history, privacy.clearOnShutdown.cookies, privacy.clearOnShutdown.cache set to true and privacy.clearOnShutdown.siteSettings set to false before switching to the new dialog.

Or alternatively, this is the expected result for fresh profiles

Comment 8

[Oana Botisan, Desktop QA]

Alright. Thank you for the answer.
I will mark this issue as VERIFIED FIXED after we had the chance to verify on beta as well.

Comment 9

[Oana Botisan, Desktop QA]

We managed to verify the fix using Firefox 128.0b1 on macOS 12, Windows 11 and Ubuntu 22.04. Everything is as expected.