1895711 - Unable to send a tab to another device

Status: VERIFIED FIXED

(Application Services :: Fxa Client, defect, P1)

Description

[Donal Meehan [:dmeehan]]

Steps to reproduce

1. Browse to a site in Fenix nightly
2. Select share from the options menu
3. Select a device from SEND TO DEVICE

Expected behavior

The site should open on the device you selected

Actual behavior

An error is displayed Unable to send

Device information

• Firefox version: 127.0a1
• Android device model: Samsung S24+
• Android OS version: Android 14

Any additional information?

This is not reproducible in 125 release or 126 beta

Comment 1

[Polly McEldowney [:pollymce]]

Attachment: stack trace - reproduced on Pixel 8, Android 14

```

```

Comment 2

[Polly McEldowney [:pollymce]]

Attachment: stack trace from pixel 8, android 14

(sorry - double post!)

Comment 3

[Tarik Eshaq [:teshaq]]

The regressor is likely https://bugzilla.mozilla.org/show_bug.cgi?id=1891157 given the timing, but I'd leave it to :lina to confirm when she's online it could be related

Comment 4

[Donal Meehan [:dmeehan]]

(In reply to Tarik Eshaq [:teshaq] from comment #3)

The regressor is likely https://bugzilla.mozilla.org/show_bug.cgi?id=1891157 given the timing, but I'd leave it to :lina to confirm when she's online it could be related

If that is the regressor and you don't have an easy fix, then could you consider reverting that change in AS?
Fx127 goes to beta next week

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Yep, either way we will get this sorted today.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

FWIW:

fxa-client-other-error: Remote server error: '400' '107' 'Bad Request' 'Invalid parameter in request body' 'https://mozilla.github.io/ecosystem-platform/api#section/Response-format'

I'll keep poking (just updating this regularly as I expect Lina will be online soon, so trying to avoid duping effort!)

Comment 7

[Lina Butler [:lina]]

I'm on it. It was a regression I introduced in https://github.com/mozilla/application-services/commit/c6fdae855cb2069b8326879bf18902c976a78159, but it's an easy fix.

Comment 8

[BMO Github Automation]

Attachment: [mozilla/application-services] Bug 1895711: Omit `ttl` fields from device commands if not set. (#6231)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://github.com/mozilla/application-services/commit/55f904c2d2522ce4495dfa4c1c6edb7abd11edde

Comment 10

[Lina Butler [:lina]]

Fenix bumped to the fixed Application Services in bug 1895763. Once that makes it to Nightly, Send Tab should be working again!

Comment 14

[Lina Butler [:lina]]

Hi folks coming to this bug—sorry for the breakage!

The fix landed in Nightly last week, but Google Play doesn't have the latest Nightlies available yet (thanks, Daniel!), so your Send Tab might still be broken.

You can install the latest Nightly from archive.mozilla.org for your architecture (that's 2024-05-12-21-26-37 at the time I wrote this comment) to get it working again.

Comment 15

[miralobontiu]

Verified as fixed on the latest Fenix Nightly 127.0a1 from 5/13, with Samsung Galaxy S24 (Android 14), and Google Pixel 6 (Android 14).

Comment 16

[Daniel Holbert [:dholbert]]

(In reply to Lina Butler [:lina] from comment #14)

You can install the latest Nightly from archive.mozilla.org for your architecture (that's 2024-05-12-21-26-37 at the time I wrote this comment) to get it working again.

(Note for folks considering this^: I recall that some methods of re-installing .apk files can cause an app's profile data to be overwritten, so that it ends up feeling like a fresh install. I don't know offhand which apk-installation methods destroy vs. preserve data. So: if you'd rather not overwrite your Firefox user data, you may want to hold off on installing .apks unless you know exactly what you're doing. :) Hopefully we'll get the updated Nightly in the play store for auto-update soon.)