1895738 - Update validation of "unhandledPromptBehavior" capability for WebDriver BiDi changes

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With bug 1884650 I'm going to update Marionette for the new unhandledPromptBehavior types. We also have to update geckodriver (webdriver) to allow correct validation of the capability.

This should block the next release of geckodriver.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I had to open a WebDriver classic specification PR to fix a couple of issues:
https://github.com/w3c/webdriver/pull/1812

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1895738 - [geckodriver] Update validation of "unhandledPromptBehavior" capability for WebDriver BiDi.

Depends on D210730

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1895738 - [wdspec] Add more tests for the unhandledPromptBehavior capability.

Depends on D210731

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d46db5db0cd
[geckodriver] Update validation of "unhandledPromptBehavior" capability for WebDriver BiDi. r=webdriver-reviewers,jgraham,jdescottes
https://hg.mozilla.org/integration/autoland/rev/967f3124eaf7
[wdspec] Add more tests for the unhandledPromptBehavior capability. r=webdriver-reviewers,jdescottes

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46429 for changes under testing/web-platform/tests

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1895738 - [remote] Fix fromJSON checks for ignore behavior in test_UserPromptHandler.js.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/124e4f18e16d
[remote] Fix fromJSON checks for ignore behavior in test_UserPromptHandler.js. CLOSED TREE

Comment 8

[Cristian Tuns]

Backed out for causing wdspec failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /webdriver/tests/classic/perform_actions/user_prompts.py | test_dismissed_beforeunload - webdriver.error.UnexpectedAlertOpenException: unexpected alert open (500): Unexpected beforeunload dialog detected. Performed handler "dismiss"

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The underlying issue for this backout is in my other patch that is part of bug 1884650.

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Kagami Rosylight [:saschanaz] (they/them)]

What's the point of moving URL to See Also? It's not the first time you are doing this and it's rather spammy than useful IMO.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Note to myself to rebase the code for geckodriver and fix merge conflicts once the patch from bug 1823907 is on mozilla-central.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48ab8b28ca67
[geckodriver] Update validation of "unhandledPromptBehavior" capability for WebDriver BiDi. r=webdriver-reviewers,jgraham,jdescottes
https://hg.mozilla.org/integration/autoland/rev/58f32a0924c8
[wdspec] Add more tests for the unhandledPromptBehavior capability. r=webdriver-reviewers,jdescottes

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/48ab8b28ca67
https://hg.mozilla.org/mozilla-central/rev/58f32a0924c8

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged