1895740 - Incorrect orders of engines in searchengine-devtools when using search-config-v2

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

With the new search config, searchengine-devtools should be able to show the same order for application search engines as Firefox will have when it first starts up on a new profile.

It appears we missed implementing the sorting in the devtools, so I'll add that here.

Comment 1

[Mark Banner (:standard8)]

Attachment: GitHub Pull Request

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1895740 - Move sorting of search engines out to a utility function. r?mcheang!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd63611adb35
Move sorting of search engines out to a utility function. r=mcheang

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bd63611adb35

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1895740 - Move sorting of search engines out to a utility function. r?mcheang!

Original Revision: https://phabricator.services.mozilla.com/D213440

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: None, this is re-arranging code so that the sorting algorithm can be reused by our searchengine-devtools add-on. This will mean that using the devtools on the new ESR will be able to return the expected default order of search engines. This is useful when checking deployments of search engines.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Moving a function into another file with a few changes, covered by tests
• String changes made/needed: None
• Is Android affected?: no

Comment 7

[Mark Banner (:standard8)]

Github PR landed in https://github.com/mozilla-extensions/searchengine-devtools/commit/e9c97bf3fc676f17d38a75dfb824b42e316815eb

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a6e51e6b6aca