1895778 - After Firefox is re-installed, the Refresh Firefox toolbar message is added to the chrome but is not focused

Status: RESOLVED FIXED

(Firefox :: Migration, defect, P3)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Focus of NVDA is placed on the page content after the Firefox was re-installed and the Refresh Firefox button is not announced

STR:

1. Ensure a screen reader is running, i.e. NVDA on WinOS
2. Remove the Firefox browser (if installed)
3. Navigate to the https://mozilla.org/en-US/firefox/new and download a new build of the browser
4. Open the installer and complete the installation of Firefox (incl. the poorly announced status page reported in bug 1889788)
5. Open the re-installed browser and observe the behavior, specifically the screen reader's announcements when the Refresh Firefox... toolbar is added under the bookmarks toolbar.
   Note: there may be a shortcut to get to this toolbar, I am not aware of it ATM

Expected:

1. The content of the toolbar is being announced by a screen reader and Refresh Firefox... button is focused instead of the content

Actual:

1. Web content is focused, a screen reader user won't be aware that they can, in fact, refresh the browser from their previous installation, until they get to the toolbar which is not an expected behavior to review content backwards. It would take them time to discover this feature, if the toolbar will be persistent.

This issue was reported by an NVDA user during a user research.

Comment 1

[:Gijs (he/him)]

Stealing focus from the notification bar is probably not ideal. I'm not sure how much control we have over the focus behaviour here in terms of the timing of the content focus vs. the appearing of the notification bar.

Are popup blocking notifications announced/alerted correctly? They should be using pretty similar notification bar styles (at least visually) so I'd expect them to behave similarly in terms of markup and a11y state, so if/where they do not that might give a hint so as to fix at least the announce-y-ness without necessarily changing focus. WDYT?

Comment 2

[Anna Yeddi [:ayeddi]]

(In reply to :Gijs (he/him) from comment #1)

Stealing focus from the notification bar is probably not ideal. I'm not sure how much control we have over the focus behaviour here in terms of the timing of the content focus vs. the appearing of the notification bar.

Are popup blocking notifications announced/alerted correctly? They should be using pretty similar notification bar styles (at least visually) so I'd expect them to behave similarly in terms of markup and a11y state, so if/where they do not that might give a hint so as to fix at least the announce-y-ness without necessarily changing focus. WDYT?

The popup blocker, i.e. from this test website, is announced in the recent Nightly 129.0a1 as expected - as an role=alert element. The moz-message-bar have been fixed with the bug 1894535 that made a moz-message-bar component an alert, but I am not sure if the notification in question (possibly, this code) is actually using moz-message-bar.

In general, I agree, if this notification would be an alert and is announcing itself on page load, the bug is fixed

Comment 3

[:Gijs (he/him)]

(In reply to Anna Yeddi [:ayeddi] ⛔ Out of office until September 5 ⛔ from comment #2)

(In reply to :Gijs (he/him) from comment #1)

Stealing focus from the notification bar is probably not ideal. I'm not sure how much control we have over the focus behaviour here in terms of the timing of the content focus vs. the appearing of the notification bar.

Are popup blocking notifications announced/alerted correctly? They should be using pretty similar notification bar styles (at least visually) so I'd expect them to behave similarly in terms of markup and a11y state, so if/where they do not that might give a hint so as to fix at least the announce-y-ness without necessarily changing focus. WDYT?

The popup blocker, i.e. from this test website, is announced in the recent Nightly 129.0a1 as expected - as an role=alert element. The moz-message-bar have been fixed with the bug 1894535 that made a moz-message-bar component an alert, but I am not sure if the notification in question (possibly, this code) is actually using moz-message-bar.

Yes, it should do - it's using a notificationBox, which is using moz-message-bar, cf. https://searchfox.org/mozilla-central/rev/8fffdc727aa507ee4955042ec2d6f71d23c9c2de/toolkit/content/widgets/notificationbox.js#624 .

I'll mark this fixed by you, then! :-)