1895867 - [wpt-sync] Sync PR 46183 - Revert "webnn: Enforce input data type constraints for gather indices"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46183 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46183
Details from upstream follow.

[e-mail] <[e-mail]> wrote:

Revert "webnn: Enforce input data type constraints for gather indices"

This reverts commit ef29e11bfb1f1f4eae0935fb58f0e4129620837b.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5728899092709376

Sample build with failed test: https://ci.chromium.org/b/8748452022241283393
Affected test(s):
ninja://services:services_unittests/WebNNGraphImplBackendTest.BuildAndComputeSingleOperatorGather

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5728899092709376&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5520313&type=BUG

Original change's description:

webnn: Enforce input data type constraints for gather indices

As specified in https://github.com/webmachinelearning/webnn/pull/646

Bug: 328567884
Change-Id: I33eba7e1def430b1cb94e3e7a4868e82c5bbd9a3
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5520313
Reviewed-by: Austin Sullivan \<[e-mail]>
Commit-Queue: Lisha Guo \<[e-mail]>
Reviewed-by: ningxin hu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1298443}

Bug: 328567884
Change-Id: Iab874e915f5603861929cdf07ba4c09698b76503
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/5528819
WPT-Export-Revision: c24972d2972f9095f56d0e82279c1ac8fe3af6c0

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 8 subtests

Status Summary

Firefox

OK : 2
FAIL: 16

Chrome

OK : 2
PASS: 16

Safari

OK : 2
FAIL: 16

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webnn/validation_tests/gather.https.any.worker.html [wpt.fyi]
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with default options and 0-D indices: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with axis = 2: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the input is a scalar: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the axis is greater than the rank of input: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the data type of indices is invalid: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] throw if input is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] throw if indices is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
• /webnn/validation_tests/gather.https.any.html [wpt.fyi]
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with default options and 0-D indices: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] Test gather with axis = 2: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the input is a scalar: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the axis is greater than the rank of input: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] TypeError is expected if the data type of indices is invalid: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] throw if input is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
  • [gather] throw if indices is from another builder: FAIL (Chrome: PASS, Safari: FAIL)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/939df97637e9
[wpt PR 46183] - Revert "webnn: Enforce input data type constraints for gather indices", a=testonly

Comment 3

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/939df97637e9