1895909 - Weird behavior with image resizer

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Marco Castelluccio [:marco]]

While resizing an image to a smaller size, the image starts sliding down and moves outside the resize box.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

I tried this and wasn't able to reproduce it - Can you provide a PDF?

Comment 2

[Marco Castelluccio [:marco]]

It's happening on any PDF for me, I think Calixte was able to reproduce and has a potential fix.

Comment 3

[Calixte Denizet (:calixte)]

It can be easily reproduced in decreasing enough the size in using one of the diagonal resizers.
It's a regression from bug 1894705 and especially from:
https://github.com/mozilla/pdf.js/pull/18019

Comment 4

[BMO Github Automation]

Attachment: [mozilla/pdf.js] Revert "Fix rendering problem when zooming on Safari" for causing bug 1895909 (#18079)

Comment 5

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Fix the CSS properties of the canvas when it's used in a stampEditor (bug 1895909) (#18080)

Comment 6

[Calixte Denizet (:calixte)]

Attachment: Bug 1895909 - Avoid to have an added image outside of its editor frame

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Added images in a pdf could be at a wrong position
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See comment#3
• Risk associated with taking this patch: Low
• Explanation of risk level: Small change and it's a backout
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1894705

Comment 9

[Daniel Bodea [:danibodea]]

I am attempting to verify this fix in all OSes, but I am having a hard time reproducing it. Could you provide some more information about its reproduction? Resizing the browser window that has a PDF with images in focus does not seem to create any unwanted behavior. Also, I don't know of a way to resize an image inside a PDF since it's a viewer and not an editor. I may have misunderstood the steps to reproduce here...
Thank you!

Comment 10

[Marco Castelluccio [:marco]]

There is a button in the toolbar, in the top right, to add an image. The first step is to add an image, then use the resizing controls (the diagonal one) to make it smaller.

Comment 11

[Daniel Bodea [:danibodea]]

I can reproduce this issue in Beta v127.0b1 and confirm the fix in Nightly v128.0a1. This issue was tested in Windows 10, MacOS 11 and Ubuntu 22.
This fix will be verified in Beta 127 when it lands. Thank you.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/fed2515635bc

Comment 13

[Daniel Bodea [:danibodea]]

This fix was verified in Beta v127.0b3 on Windows 10, MacOS 11 and Ubuntu 22.