1895934 - Improve handling of search term parameter names

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

With the new search configuration, we now have a dedicated searchTermParamName. For application provided engines, we should be able to use those details directly, rather than going through the conversion to a URL and look for {searchTerms} process.

It might be that we extend EngineURLs with a specific option for the search term, rather than having AppProvidedSearchEngine add a "normal" parameter.

Some exploration might be needed for the best way of doing this. Ideally, we'd potentially only process once the search term parameter name for other engine types as well.

Whilst here, or maybe in a follow-up, we should also update SearchEngine.searchTermFromResult to get the search term parameter name directly, rather than going through getURLParsingInfo(). This would be more efficient in avoiding unnecessary conversions of the URL template to a nsIURI.

Comment 1

[Moritz Beier [:mbeier]]

Attachment: Bug 1895934 - Improve handling of search term parameter names. r?standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa2e407806fa
Improve handling of search term parameter names. r=Standard8

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing docu perma failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/7a925f96907d627e7f808399c82155fe74828165

Push with failures

Failure log -> sphinx.errors.ExtensionError: Handler <function analyze at 0x7f40ece69620> for event 'builder-inited' threw an exception (exception: Your code contains multiple documented objects at each of these paths:

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d583c7e6ed7
Improve handling of search term parameter names. r=Standard8

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing docu perma failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/57a73a854a08b460c721a973cbca8879a1f3cf81

Push with failures

[Failure log -> https://treeherder.mozilla.org/logviewer?job_id=477680830&repo=autoland&lineNumber=810](sphinx.errors.ExtensionError: Handler <function analyze at 0x7f61129ecea0> for event 'builder-inited' threw an exception (exception: Your code contains multiple documented objects at each of these paths:)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b7becf05898
Improve handling of search term parameter names. r=Standard8

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3b7becf05898