1895943 - Implement file picker and save location for backups

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[kpatenio]

The dialog for turning on scheduled backups (see Bug 1893277) has an input that users can interact with to choose the save location for backups. This is a follow-up ticket to implement the file picker associated with that UI. Some things to consider:

1. The input shows a folder icon for the selected folder
2. There is a "recommended" folder that's displayed by default, but users can select a non default folder if desired
3. "(recommended)" text in the input should be localized
4. Once all options in the modal are confirmed, the new backup location should be saved and passed to BackupService

Comment 1

[kpatenio]

Some other details from the spec that are relevant to save location:

• There will be an option to choose the location of the backup
• The default location will be the Documents folder
• On Windows call SHGetKnownFolderPath(FOLDERID_Documents
• On macOS call NSSearchPathForDirectoriesInDomains(NSDocumentDirectory
• On Linux use $XDG_DOCUMENTS_DIR variable in ~/.config/user-dirs.dirs, or if that doesn’t exist, use $HOME/Documents
• There will be an affordance to pick a different location using the OS standard folder picker

Comment 2

[kpatenio]

Attachment: Bug 1895943 - Implement file picker and save location for backups. r=#backup-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dd8df7eb584
Implement file picker and save location for backups. r=backup-reviewers,mconley,fluent-reviewers,flod,firefox-desktop-core-reviewers

Comment 4

[Cristian Tuns]

Backed out for causing bc failures in browser_startup_mainthreadio.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_mainthreadio.js | unexpected read on D:\task_171808496973085\AppData\Roaming\Microsoft\Windows\Libraries\desktop.ini before becoming idle -

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aca723da347d
Implement file picker and save location for backups. r=backup-reviewers,fluent-reviewers,flod,firefox-desktop-core-reviewers

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/aca723da347d