1895960 - Only pass the queryCharset through to ParamSubstitution rather than a full engine object

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

In the SearchEngine / EngineURL we are passing a full SearchEngine object through getSubmission and onto ParamSubstitution. However, we are only using the queryCharset from that engine.

The problem with this is that it makes it unclear what getSubmission and ParamSubstitution are actually doing with the engine object. I think it would be clearer and simpler to only pass the queryCharset.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1895960 - Only pass the queryCharset through to ParamSubstitution rather than a full engine object. r?#search-reviewers!

This helps with clarity to know exactly what getSubmission/ParamSubstitution require, rather than passing a general engine object, which could be anything.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cb9241bfb7e
Only pass the queryCharset through to ParamSubstitution rather than a full engine object. r=search-reviewers,daleharvey

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5cb9241bfb7e