1895962 - Add a shipitscript task that updates the Nightly version in shipit if necessary once the builds are in the Mozilla archive

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, enhancement, P3)

Description

[Gabriel Bustamante [:gabriel]]

Once we have an API to manage the Nightly version in shipit, and scriptworker support for calling this API, we need to add a task to the Nightly graph to trigger the worker's behavior once the builds are in the archive.

Comment 1

[Gabriel Bustamante [:gabriel]]

Attachment: Bug 1895962 - Add a shipitscript task that updates the Nightly version in shipit if necessary once the builds are in the Mozilla archive r=hneiva,#releng-reviewers

Comment 2

[Cristian Tuns]

Backed out for causing Gecko decision task bustages in gecko_taskgraph.loader.transform

• Backout link
• Push with failures
• Failure Log
• Failure line: ModuleNotFoundError: No module named 'gecko_taskgraph.loader.transform'

Comment 3

[Gabriel Bustamante [:gabriel]]

The fix is queued.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06fde1bb5f54
Add a shipitscript task that updates the Nightly version in shipit if necessary once the builds are in the Mozilla archive r=hneiva,releng-reviewers,taskgraph-reviewers

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/06fde1bb5f54

Comment 6

[Gabriel Bustamante [:gabriel]]

Attachment: Bug 1895962 - Fix the release-update-product-channel-version kind that disappeared post taskgraph update r=#releng-reviewers,#taskgraph-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fb4dc99349f
Fix the release-update-product-channel-version kind that disappeared post taskgraph update r=releng-reviewers,taskgraph-reviewers,bhearsum

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0fb4dc99349f

Comment 9

[Cristian Tuns]

Backed out for causing cron job failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: http://taskcluster/queue/v1/task/O4NH5MWIRgS5wgVDBo4imA

Comment 10

[Julien Cristau [:jcristau]]

I'm not a fan of how scopes work here. Until now mozilla-central hasn't needed to talk to production shipit, but if we grant it that scope then that also means it can create new releases, or mark them as shipped, for any and all products. That may not need to block this bug, but can we look at making things more granular?

Comment 11

[Gabriel Bustamante [:gabriel]]

Thanks Julien.

So, grating project:releng:ship-it:server:production to mozilla-central would enable it to call all the actions on all the products?

That kinda sucks :C

Is it because we grant the actions to the gecko trust domain?

I see some references to "products" in the worker's client scopes, but they apply to all the gecko-3 workers.

...
project/releng/scriptworker/v2/shipit/prod/firefoxci-gecko-3:
  description: ''
  scopes:
    - project:releng:services/shipit_api/update_product_channel_version/firefox
    - project:releng:services/shipit_api/add_release/devedition
    - project:releng:services/shipit_api/add_release/fennec
    - project:releng:services/shipit_api/add_release/firefox
...

Comment 12

[Gabriel Bustamante [:gabriel]]

Could we make it more granular using the project alias?

Comment 13

[Gabriel Bustamante [:gabriel]]

I already landed patches to shipit to use the non-hard-coded version so it would be nice if I could close this bug before merge day. But, if I need more time to refactor the scopes... I can grant releng access to update the version in shipit (right now only the workers can call the API) and bump it myself (if I need to.)

Comment 14

[Gabriel Bustamante [:gabriel]]

Attachment: Bug 1895962 - Grant the Nightly cron jobs scopes to run actions on the production ship-it server r=jcristau,#releng-reviewers

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/ci/ci-configuration/rev/9f31d79ce94b
Grant the Nightly cron jobs scopes to run actions on the production ship-it server r=jcristau,releng-reviewers

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20c9105b1f84
Fix the release-update-product-channel-version kind that disappeared post taskgraph update r=releng-reviewers,taskgraph-reviewers,bhearsum

Comment 17

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/20c9105b1f84