Closed Bug 1896018 Opened 9 months ago Closed 9 months ago

[wpt-sync] Sync PR 46192 - [FedCM] Replace the scopes API with the fields API

Categories

(Core :: DOM: Credential Management, task, P4)

task

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 46192 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46192
Details from upstream follow.

Christian Biesinger <cbiesinger@chromium.org> wrote:

[FedCM] Replace the scopes API with the fields API

This implements the new proposal here:
https://github.com/fedidcg/FedCM/issues/559

If one or two but not all of ["name", "email", "picture"] are requested,
we reject the promise. Otherwise, we show the disclosure text if
either field is not specified or contains the three default fields.
All specified fields are passed to the server in the "fields" parameter;
if fields was unspecified we pass the default fields here.

All this is for forwards compatibility.

Bug: 40262526
Change-Id: I13833691e5f2851f0dc8e9568d007e57a47b8127
Reviewed-on: https://chromium-review.googlesource.com/5529071
WPT-Export-Revision: 87ef80d4473117046f5c9d8f497214b308e2c0be

PR 46192 applied with additional changes from upstream: 84b308dada590743babc02b2899a596da62094d1
Component: web-platform-tests → DOM: Credential Management
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

TIMEOUT: 2
NOTRUN : 3

Chrome

TIMEOUT: 2
NOTRUN : 3

Safari

OK : 1
FAIL : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /credential-management/fedcm-authz/fedcm-disclosure-text-shown.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: OK)
    • We should send disclosure_text_shown=false when custom fields are passed.: TIMEOUT (Chrome: TIMEOUT, Safari: FAIL)
    • We should send disclosure_text_shown=false when an empty custom fields array is passed.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
    • We should send disclosure_text_shown=true when no custom fields are passed.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
    • We should send disclosure_text_shown=true when custom fields are passed in addition to standard fields.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /credential-management/fedcm-authz/fedcm-disclosure-text-shown.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/161788c0a0e7 [wpt PR 46192] - [FedCM] Replace the scopes API with the fields API, a=testonly
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
Regressions: 1898128
You need to log in before you can comment on or make changes to this bug.