Closed Bug 189604 Opened 22 years ago Closed 17 years ago

No need for .descent member in nsHTMLReflowMetrics

Categories

(Core :: Layout, defect, P1)

Product:
Core
Component:
Layout
Platform:
x86
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha2

People

(Reporter: bzbarsky, Assigned: dbaron)

References

Details

Since we must always have |descent + ascent == height| (rbs, that's correct,
no?), there is no reason to have a .descent member in the reflow metrics.  We
should just have the ascent and the height....
Priority: -- → P1
Target Milestone: --- → mozilla1.4alpha
Well, the only people who even _use_ these for something are table row frames
and MathML.  It looks to me like table row frames could easily use ascent
instead of descent as long as the invariant |heigth = ascent + descent| is being
maintained.  

That leaves MathML.  rbs?  Comments?
Okay with me too. But regarding such changes, my favorite is bug 64763.
Ah.  Hmm.  That may indeed be better..... I'll move some comments to there.
Depends on: 64763
Target Milestone: mozilla1.4alpha → mozilla1.5beta
Depends on: 367332
I fixed this as part of bug 367332.
Assignee: bzbarsky → dbaron
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.5beta → mozilla1.9alpha2
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.