Open Bug 1896081 Opened 1 year ago Updated 1 year ago

Do not call this.get() unconditionally in injectInto() in Schemas.sys.mjs

Categories

(WebExtensions :: General, defect, P3)

defect

Tracking

(firefox-esr115 fix-optional, firefox126 wontfix, firefox127 wontfix, firefox128 fix-optional, firefox129 fix-optional)

Tracking Status
firefox-esr115 --- fix-optional
firefox126 --- wontfix
firefox127 --- wontfix
firefox128 --- fix-optional
firefox129 --- fix-optional

People

(Reporter: john, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Summary: Do not call this.get() uncoditionaly in injectInto() in Schemas.sys.mjs → Do not call this.get() unconditionally in injectInto() in Schemas.sys.mjs

For context, the original optimization was introduced in bug 1338409.

The optimization was partially undone by changes in bug 1693403.

Severity: -- → N/A
Type: task → defect
Keywords: regression
Priority: -- → P3
Regressed by: 1693403
See Also: → 1338409

:mixedpuppy, since you are the author of the regressor, bug 1693403, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(mixedpuppy)

Set release status flags based on info from the regressing bug 1693403

Flags: needinfo?(mixedpuppy)

The severity field is not set for this bug.
:rpl, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(lgreco)

Will, can you help set a severity for this bug? I'm not clear of the effect of this regression, but we are coming across it in triage. If it's not a high priority and severity, we can drop it from the triage. But if you think it should be fixed soon, can you help find an owner? Thanks!

Flags: needinfo?(wdurand)

No need to track this. The only impact is slightly more memory usage and a bit of waste of CPU time than the ideal situation.

Severity: N/A → S3
Flags: needinfo?(wdurand)
Flags: needinfo?(lgreco)
You need to log in before you can comment on or make changes to this bug.