1896083 - Do not upgrade domains that do not end with a valid TLD

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement)

Description

[Malte Jürgens [:maltejur]]

This would be a easy way to exempt local domains like site.local or router.lan from HTTPS-First. We should also consider if we want to do the same for HTTPS-Only.

Comment 1

[Malte Jürgens [:maltejur]]

Attachment: Bug 1896083 - Do not HTTPS-First upgrade hostnames that do not end with a known public suffix r?simonf!,freddyb!

Comment 2

[Malte Jürgens [:maltejur]]

Attachment: Bug 1896083 - Add functionality to eTLD service to check if hostname ends in known public suffix r?#necko-reviewers!,mak!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b206d79cd48
Add functionality to eTLD service to check if hostname ends in known public suffix r=mak,necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/2d286815be60
Do not HTTPS-First upgrade hostnames that do not end with a known public suffix r=necko-reviewers,valentin,simonf,freddyb

Comment 4

[Cristian Tuns]

Backed out for causing browser_httpsfirst.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/security/test/https-first/browser_httpsfirst.js | Should not downgrade on dnsNotFound error. - false == true -

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e2450e990ce
Add functionality to eTLD service to check if hostname ends in known public suffix r=mak,necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/c2de598b0433
Do not HTTPS-First upgrade hostnames that do not end with a known public suffix r=necko-reviewers,valentin,simonf,freddyb

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/1e2450e990ce
https://hg.mozilla.org/mozilla-central/rev/c2de598b0433